Skip to content

[frontend] User With Access Data Sharing capability should be able to open stream via menu item (#14802)#14815

Merged
Archidoit merged 3 commits intomasterfrom
issue/14802
Mar 6, 2026
Merged

[frontend] User With Access Data Sharing capability should be able to open stream via menu item (#14802)#14815
Archidoit merged 3 commits intomasterfrom
issue/14802

Conversation

@Archidoit
Copy link
Member

@Archidoit Archidoit commented Mar 6, 2026

Proposed changes

  • Convert StreamPopover.jsx to tsx pure function
  • Users with the 'access data sharing' capability should be able to open the menu item for a live stream
    and have the 'open stream' possibility only if they have not the 'manage data sharing' capability
image

and have all other possibilities if they have the 'manage data sharing' capability
image

Related issues

#14802

@Archidoit Archidoit self-assigned this Mar 6, 2026
@Archidoit Archidoit added the filigran team use to identify PR from the Filigran team label Mar 6, 2026
@Archidoit Archidoit changed the title [frontend] Fix User With Access Data Sharing capability can't open stream via menu item (#14802) [frontend] User With Access Data Sharing capability should be able to open stream via menu item (#14802) Mar 6, 2026
@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

❌ Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.35%. Comparing base (789b88a) to head (eb55c98).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...c/private/components/data/stream/StreamPopover.tsx 0.00% 33 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #14815   +/-   ##
=======================================
  Coverage   32.35%   32.35%           
=======================================
  Files        3111     3111           
  Lines      211873   211861   -12     
  Branches    38394    38396    +2     
=======================================
+ Hits        68554    68557    +3     
+ Misses     143319   143304   -15     
Flag Coverage Δ
opencti-client-python 45.53% <ø> (ø)
opencti-front 2.82% <0.00%> (+<0.01%) ⬆️
opencti-graphql 67.56% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Archidoit Archidoit merged commit 9fff186 into master Mar 6, 2026
36 checks passed
@Archidoit Archidoit deleted the issue/14802 branch March 6, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants