Skip to content

[frontend] Disabled workflows can not be activated on entities (#14800)#14820

Merged
SarahBocognano merged 1 commit intomasterfrom
issue/14800
Mar 6, 2026
Merged

[frontend] Disabled workflows can not be activated on entities (#14800)#14820
SarahBocognano merged 1 commit intomasterfrom
issue/14800

Conversation

@SarahBocognano
Copy link
Member

Proposed changes

  • Allow the creation of a status even when disabled

The problem that occurs here is that to be allowed to manipulate workflow we set the attribute " workflow_configuration " at true during the initialization of the entity settings.
BUT, we are looking at the attribute "workflowEnabled" (which is a boolean telling us if there is status created on this entity or not) to allow the add/edit of the workflow.

This was a case of egg and chicken here, as the workflowEnabled could never be at true if we are not capable of creating a status in the first place...

My solution here is to allow the edition even if there is no status to allow the user to use workflow if the attribute worklow_configuration is set at true.

An other solution is to maybe look at the workflow_configuration in the backend (isGlobalWorkflowEnabled function)to allow workflow, instead of looking at if status exists.

Related issues

@SarahBocognano SarahBocognano self-assigned this Mar 6, 2026
@SarahBocognano SarahBocognano added the filigran team use to identify PR from the Filigran team label Mar 6, 2026
@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.35%. Comparing base (80ce21b) to head (7f97b5e).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #14820   +/-   ##
=======================================
  Coverage   32.35%   32.35%           
=======================================
  Files        3111     3111           
  Lines      211872   211872           
  Branches    38395    38396    +1     
=======================================
  Hits        68557    68557           
  Misses     143315   143315           
Flag Coverage Δ
opencti-client-python 45.53% <ø> (ø)
opencti-front 2.82% <ø> (ø)
opencti-graphql 67.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SarahBocognano SarahBocognano merged commit 86adda6 into master Mar 6, 2026
36 checks passed
@SarahBocognano SarahBocognano deleted the issue/14800 branch March 6, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants