perf(animation): drop bouncy springs on high-frequency UI (E4.2)#549
Conversation
WalkthroughThis PR systematically refines animation behavior across multiple UI components. Tab indicator positioning switches from bouncy spring dynamics to predictable 250ms tween easing. Icon, label, and chip scale animations reduce damping and adjust stiffness for less bouncy, more responsive interactions across bottom navigation, filter chips, and settings screens. ChangesAnimation Parameter Refinement
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
feature/tweaks/presentation/src/commonMain/kotlin/zed/rainxch/tweaks/presentation/components/sections/Appearance.kt (1)
285-292:⚠️ Potential issue | 🟡 Minor | ⚡ Quick win
ThemeColorOptionscale spring was not updated — contradicts the stated PR objective.The PR objectives explicitly list this surface as a target:
Tweaks → Appearance → ThemeColorOption scale:
spring(MediumBouncy, StiffnessLow)→spring(NoBouncy, StiffnessMedium)Lines 289–291 still use
DampingRatioMediumBouncy/StiffnessLow.ThemeColorOptionlives in aLazyRowof color swatches that users tap freely, putting it in the same high-frequency category as the surfaces that were fixed.(Line 331's
scaleIn(spring(MediumBouncy))insideAnimatedVisibilityis intentionally left bouncy as a one-shot checkmark entrance — that is correct and should not change.)🐛 Proposed fix
val scale by animateFloatAsState( targetValue = if (isSelected) 1.1f else 1f, animationSpec = spring( - dampingRatio = Spring.DampingRatioMediumBouncy, - stiffness = Spring.StiffnessLow, + dampingRatio = Spring.DampingRatioNoBouncy, + stiffness = Spring.StiffnessMedium, ), )🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@feature/tweaks/presentation/src/commonMain/kotlin/zed/rainxch/tweaks/presentation/components/sections/Appearance.kt` around lines 285 - 292, The scale spring used by ThemeColorOption was not updated: change the animateFloatAsState animationSpec for the scale variable (in ThemeColorOption) from spring(dampingRatio = Spring.DampingRatioMediumBouncy, stiffness = Spring.StiffnessLow) to spring(dampingRatio = Spring.DampingRatioNoBouncy, stiffness = Spring.StiffnessMedium) so the ThemeColorOption uses the intended NoBouncy/Medium stiffness behavior; keep the separate scaleIn(spring(MediumBouncy)) for the AnimatedVisibility checkmark unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In
`@feature/tweaks/presentation/src/commonMain/kotlin/zed/rainxch/tweaks/presentation/components/sections/Appearance.kt`:
- Around line 285-292: The scale spring used by ThemeColorOption was not
updated: change the animateFloatAsState animationSpec for the scale variable (in
ThemeColorOption) from spring(dampingRatio = Spring.DampingRatioMediumBouncy,
stiffness = Spring.StiffnessLow) to spring(dampingRatio =
Spring.DampingRatioNoBouncy, stiffness = Spring.StiffnessMedium) so the
ThemeColorOption uses the intended NoBouncy/Medium stiffness behavior; keep the
separate scaleIn(spring(MediumBouncy)) for the AnimatedVisibility checkmark
unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 9cdb22d3-57d7-4366-a4a9-a89e24906a73
📒 Files selected for processing (4)
composeApp/src/commonMain/kotlin/zed/rainxch/githubstore/app/navigation/BottomNavigation.ktfeature/home/presentation/src/commonMain/kotlin/zed/rainxch/home/presentation/components/HomeFilterChips.ktfeature/tweaks/presentation/src/commonMain/kotlin/zed/rainxch/tweaks/presentation/components/sections/Appearance.ktfeature/tweaks/presentation/src/commonMain/kotlin/zed/rainxch/tweaks/presentation/components/sections/Installation.kt
1 participant
Survey #16: "reduce acceleration and bounce animations". Slice E4.2 of E4 Performance Pass.
What
Targeted bounce reduction on high-frequency selection animations only. Removed
Spring.DampingRatioMediumBouncy/LowBouncyovershoot from the surfaces a user hits dozens of times per session. Kept subtle bounces on one-shot animations (auth flow enter/exit, dialog scale-in) where the personality is intentional and not jarring.Changes
BottomNavigationindicator X positionspring(LowBouncy, StiffnessLow)tween(250ms, FastOutSlowInEasing)BottomNavigationicon scale on selectionspring(MediumBouncy, StiffnessLow)spring(NoBouncy, StiffnessMedium)BottomNavigationicon offset YBottomNavigationlabel scaleHomeFilterChipsindicator Xspring(LowBouncy, StiffnessLow)tween(220ms)HomeFilterChipspress scalespring(MediumBouncy, StiffnessMedium)spring(NoBouncy, StiffnessMediumLow)Tweaks → Appearance → ThemeModeOptionscalespring(MediumBouncy, StiffnessLow)spring(NoBouncy, StiffnessMedium)Tweaks → Appearance → ThemeColorOptionscaleTweaks → Installation → InstallerOptionscalespring(MediumBouncy, StiffnessLow)spring(NoBouncy, StiffnessMedium)Skipped (intentional bounce kept)
AuthenticationRoot— one-time auth flow, the bounce reads as personality not jitter.BottomNavigation.pressScale— micro press feedback at 0.85x; the subtle bounce IS the touch confirmation.Appearance.kt:331scaleIn(spring(MediumBouncy))insideAnimatedVisibility— one-shot enter animation only fires when the chip becomes selected; not high-frequency.Test plan
:composeApp:compileDebugKotlinAndroid✅RELEASE_NOTES_1.8.1.md(out-of-scope untracked file) → skipped.Why surface count is small
The codebase already used
Spring.DampingRatioNoBouncyextensively. Only 5 files had bouncy springs. Of those, only 4 surfaces are high-frequency — easy + bounded sweep.Out of scope
Application.onCreate/MainActivity.onCreate.DetailsViewModel.loadDetailsparallelasync {}.Summary by CodeRabbit