Skip to content

perf(animation): drop bouncy springs on high-frequency UI (E4.2) #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rainxchzed merged 1 commit into from
May 8, 2026
Merged

perf(animation): drop bouncy springs on high-frequency UI (E4.2) #549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions composeApp/src/commonMain/kotlin/zed/rainxch/githubstore/app/navigation/BottomNavigation.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,13 +86,12 @@ fun BottomNavigation(
val targetX = raw.first + rowHorizontalPaddingPx - indicatorHorizontalInsetPx
val targetW = raw.second + indicatorHorizontalInsetPx * 2f
launch {
// E4.2: tab indicator animated via tween — bouncy spring on a
// high-frequency tap target overshoots on every tab change and
// reads as jittery (survey #16). Tween stays predictable.
indicatorX.animateTo(
targetValue = targetX,
animationSpec =
spring(
dampingRatio = Spring.DampingRatioLowBouncy,
stiffness = Spring.StiffnessLow,
),
animationSpec = tween(durationMillis = 250, easing = FastOutSlowInEasing),
)
}
launch {
Expand Down Expand Up @@ -289,8 +288,8 @@ private fun LiquidGlassTabItem(
targetValue = if (isSelected) 1.15f else 1f,
animationSpec =
spring(
dampingRatio = Spring.DampingRatioMediumBouncy,
stiffness = Spring.StiffnessLow,
dampingRatio = Spring.DampingRatioNoBouncy,
stiffness = Spring.StiffnessMedium,
),
label = "iconScale",
)
Expand All @@ -299,8 +298,8 @@ private fun LiquidGlassTabItem(
targetValue = if (isSelected) (-1).dp else 1.dp,
animationSpec =
spring(
dampingRatio = Spring.DampingRatioMediumBouncy,
stiffness = Spring.StiffnessLow,
dampingRatio = Spring.DampingRatioNoBouncy,
stiffness = Spring.StiffnessMedium,
),
label = "iconOffsetY",
)
Expand All @@ -326,8 +325,8 @@ private fun LiquidGlassTabItem(
targetValue = if (isSelected) 1f else 0.6f,
animationSpec =
spring(
dampingRatio = Spring.DampingRatioMediumBouncy,
stiffness = Spring.StiffnessLow,
dampingRatio = Spring.DampingRatioNoBouncy,
stiffness = Spring.StiffnessMedium,
),
label = "labelScale",
)
Expand Down
13 changes: 6 additions & 7 deletions ...ntation/src/commonMain/kotlin/zed/rainxch/home/presentation/components/HomeFilterChips.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,13 +83,12 @@ fun LiquidGlassCategoryChips(
val targetW = raw.second + insetPx * 2f

launch {
// E4.2: tween over spring for the chip-row indicator — same
// jitter rationale as BottomNavigation. Selecting a category
// hundreds of times per session shouldn't overshoot.
indicatorX.animateTo(
targetValue = targetX,
animationSpec =
spring(
dampingRatio = Spring.DampingRatioLowBouncy,
stiffness = Spring.StiffnessLow,
),
animationSpec = tween(durationMillis = 220),
)
}
launch {
Expand Down Expand Up @@ -290,8 +289,8 @@ private fun LiquidGlassCategoryChip(
targetValue = if (isPressed) 0.90f else 1f,
animationSpec =
spring(
dampingRatio = Spring.DampingRatioMediumBouncy,
stiffness = Spring.StiffnessMedium,
dampingRatio = Spring.DampingRatioNoBouncy,
stiffness = Spring.StiffnessMediumLow,
),
label = "chipPressScale",
)
Expand Down
4 changes: 2 additions & 2 deletions ...n/src/commonMain/kotlin/zed/rainxch/tweaks/presentation/components/sections/Appearance.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,8 +186,8 @@ private fun ThemeModeOption(
targetValue = if (isSelected) 1.05f else 1f,
animationSpec =
spring(
dampingRatio = Spring.DampingRatioMediumBouncy,
stiffness = Spring.StiffnessLow,
dampingRatio = Spring.DampingRatioNoBouncy,
stiffness = Spring.StiffnessMedium,
),
)

Expand Down
4 changes: 2 additions & 2 deletions ...src/commonMain/kotlin/zed/rainxch/tweaks/presentation/components/sections/Installation.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,8 +512,8 @@ private fun InstallerOption(
val scale by animateFloatAsState(
targetValue = if (isSelected) 1.02f else 1f,
animationSpec = spring(
dampingRatio = Spring.DampingRatioMediumBouncy,
stiffness = Spring.StiffnessLow
dampingRatio = Spring.DampingRatioNoBouncy,
stiffness = Spring.StiffnessMedium
)
)

Expand Down