Add custom target for materialx shaders module build#33
Open
jlanz wants to merge 1 commit into
Open
Conversation
Signed-off-by: Jon Lanz <jon.lanz@dreamworks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compatibility:
build
Issues/Tickets:
MOONSHINE-2017
Release notes comment:
Reverts bug fix from MOONSHINE-2017
Comments for the reviewer:
This PR reverts a prior MOONSHINE-2017 change in the eye caustic BSDF by removing the clamp applied to the incident-
direction cosine term, restoring the previous raw dot(N, wi) behavior.
Changes:
Removed the min(..., sOneMinusEpsilon) clamp when computing eyeCausticBrdfCosThetaI in
EyeCausticBsdfLobe::eval() .
Look or scene setup change:
Special notes for production:
Attention/Reviewers:
AI Assisted Development:
Checklist: