Skip to content

Revert change to eye caustic BSDF #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jlanz merged 1 commit into from
Jul 15, 2026
+1 −1
Merged

Revert change to eye caustic BSDF #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rendering/shading/bsdf/BsdfEyeCaustic.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ class EyeCausticBsdfLobe : public BsdfLobe
const float cosThetaO = dot(mN, slice.getWo());
if (cosThetaO <= 0.0f) return scene_rdl2::math::sBlack;

const float eyeCausticBrdfCosThetaI = scene_rdl2::math::min(dot(mFrame.getN(), wi), scene_rdl2::math::sOneMinusEpsilon);
const float eyeCausticBrdfCosThetaI = dot(mFrame.getN(), wi);
if (eyeCausticBrdfCosThetaI <= 0.0f) return scene_rdl2::math::sBlack;

// Normalization Factor from [1]
Expand Down