Skip to content

solium: remove the arg-overflow rule - #7

Closed
come-maiz wants to merge 1 commit into
masterfrom
remove-argoverflow
Closed

solium: remove the arg-overflow rule#7
come-maiz wants to merge 1 commit into
masterfrom
remove-argoverflow

Conversation

@come-maiz

Copy link
Copy Markdown

No description provided.

Comment thread .soliumrc.json
"no-empty-blocks": "off",
"indentation": ["error", 2],
"max-len": ["error", 79],
"arg-overflow": ["warning", 3],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one of the default rules, so we need to explicitly disable it:

"arg-overflow": "off"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could add some sample code to this repo, showcasing the style (and checking that our ruleset works with no warnings).

@come-maiz

Copy link
Copy Markdown
Author

Thanks for catching this, twice @nventuro :)
I'm closing this one in favor of #8. Please review that one.

@come-maiz come-maiz closed this Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants