Remove the arg-overflow rule, with tests - #8
Conversation
| let dedent = require("dedent"); | ||
| let Solium = require("solium"); | ||
|
|
||
| let userConfig = JSON.parse(fs.readFileSync('.soliumrc.json', 'utf8')); |
There was a problem hiding this comment.
Why let instead of const? Do we have (should we have) a rule for this?
There was a problem hiding this comment.
I've proposed #9 to add this rule.
Now this brings a super good topic, we were not running the linter on this code. I've updated the branch to do so.
TODO for later: add tests for the eslint rules.
|
|
||
| errors.should.deepEqual([]); | ||
|
|
||
| done(); |
There was a problem hiding this comment.
I thought done() was only used when doing async tests without async/await?
| function testFunc(uint arg1, uint arg2, uint arg3, uint arg4) public { | ||
| } | ||
| }`, | ||
| errors = Solium.lint(code, userConfig); |
There was a problem hiding this comment.
I find the let a = expr, b = expr syntax confusing, is there a reason to have both assignments on the same line?
|
@nventuro the answer to all your questions is that I've just copied the style from solium. So I appreciate a lot your comments, they help me find what's good JS and what's not. Without calling I've pushed an update. |
2 participants
No description provided.