Limit composer dist to src/, bin/ and a few informative files#1424
Closed
spawnia wants to merge 1 commit intoPHPOffice:masterfrom
spawnia:patch-1
Closed
Limit composer dist to src/, bin/ and a few informative files#1424spawnia wants to merge 1 commit intoPHPOffice:masterfrom spawnia:patch-1
spawnia wants to merge 1 commit intoPHPOffice:masterfrom
spawnia:patch-1
Conversation
While the docs and samples are great, i do not need them in my vendor directory. The same is true for the many configuration files. A few select files such as the readme, changelog and contributing information were deliberately left in. We can remove those too if you think that is better.
PowerKiKi
added a commit
that referenced
this pull request
May 31, 2020
### Added - Support writing to streams in all writers [#1292](#1292) - Support CSV files with data wrapping a lot of lines [#1468](#1468) - Support protection of worksheet by a specific hash algorithm [#1485](#1485) ### Fixed - Fix Chart samples by updating chart parameter from 0 to DataSeries::EMPTY_AS_GAP [#1448](#1448) - Fix return type in docblock for the Cells::get() [#1398](#1398) - Fix RATE, PRICE, XIRR, and XNPV Functions [#1456](#1456) - Save Excel 2010+ functions properly in XLSX [#1461](#1461) - Several improvements in HTML writer [#1464](#1464) - Fix incorrect behaviour when saving XLSX file with drawings [#1462](#1462), - Fix Crash while trying setting a cell the value "123456\n" [#1476](#1481) - Improved DATEDIF() function and reduced errors for Y and YM units [#1466](#1466) - Stricter typing for mergeCells [#1494](#1494) ### Changed - Drop support for PHP 7.1, according to https://phpspreadsheet.readthedocs.io/en/latest/#php-version-support - Drop partial migration tool in favor of complete migration via RectorPHP [#1445](#1445) - Limit composer package to `src/` [#1424](#1424)
|
I'd always thought it was too much having samples and some other "unnecessary" files in a vendor, however they would usually come really handy for someone using the package for the first couple of times. I speak from experience. I can't count the number of times I looked at the sample files to understand how to go about certain things. To that end, I'd suggest why not have those samples as a standalone package? Too much? I can try to help with that |
Contributor
Author
|
|
Mad! 😂 Actually didn't even think of that! Damn! |
BlackyTay
pushed a commit
to BlackyTay/PhpSpreadsheet
that referenced
this pull request
Aug 8, 2025
While there is value in providing those, they also clutter IDE auto-complete feature. Now they users can opt-in to download them via `--prefer-source` flag. Closes PHPOffice#908 Closes PHPOffice#1424
BlackyTay
pushed a commit
to BlackyTay/PhpSpreadsheet
that referenced
this pull request
Aug 8, 2025
### Added - Support writing to streams in all writers [PHPOffice#1292](PHPOffice#1292) - Support CSV files with data wrapping a lot of lines [PHPOffice#1468](PHPOffice#1468) - Support protection of worksheet by a specific hash algorithm [PHPOffice#1485](PHPOffice#1485) ### Fixed - Fix Chart samples by updating chart parameter from 0 to DataSeries::EMPTY_AS_GAP [PHPOffice#1448](PHPOffice#1448) - Fix return type in docblock for the Cells::get() [PHPOffice#1398](PHPOffice#1398) - Fix RATE, PRICE, XIRR, and XNPV Functions [PHPOffice#1456](PHPOffice#1456) - Save Excel 2010+ functions properly in XLSX [PHPOffice#1461](PHPOffice#1461) - Several improvements in HTML writer [PHPOffice#1464](PHPOffice#1464) - Fix incorrect behaviour when saving XLSX file with drawings [PHPOffice#1462](PHPOffice#1462), - Fix Crash while trying setting a cell the value "123456\n" [PHPOffice#1476](PHPOffice#1481) - Improved DATEDIF() function and reduced errors for Y and YM units [PHPOffice#1466](PHPOffice#1466) - Stricter typing for mergeCells [PHPOffice#1494](PHPOffice#1494) ### Changed - Drop support for PHP 7.1, according to https://phpspreadsheet.readthedocs.io/en/latest/#php-version-support - Drop partial migration tool in favor of complete migration via RectorPHP [PHPOffice#1445](PHPOffice#1445) - Limit composer package to `src/` [PHPOffice#1424](PHPOffice#1424)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the docs and samples are great, i do not need them in my vendor directory. The same is true for the many configuration files.
A few select files such as the readme, changelog and contributing information were deliberately left in. We can remove those too if you think that is better.