fix: issue #1476 crash with numeric string value terminating with new line#1481
Merged
MarkBaker merged 5 commits intoPHPOffice:masterfrom May 23, 2020
Merged
fix: issue #1476 crash with numeric string value terminating with new line#1481MarkBaker merged 5 commits intoPHPOffice:masterfrom
MarkBaker merged 5 commits intoPHPOffice:masterfrom
Conversation
… with new line
… with new line
… with new line
Contributor
|
Hi again :) By the way, it is useful to mention related issues in the PR, like sescribed here. |
Contributor
Author
|
its mentioned in the title maybe i did it wrong, sorry, this is the forst time for me |
Contributor
Just read this article.
That's why I gave you the hint ;) |
Contributor
Author
|
Thank you! |
Contributor
|
I see you did all right! :) 👍 |
Member
|
Thank you for providing the PR to resolve this issue. |
Member
|
Thanks |
PowerKiKi
added a commit
that referenced
this pull request
May 31, 2020
### Added - Support writing to streams in all writers [#1292](#1292) - Support CSV files with data wrapping a lot of lines [#1468](#1468) - Support protection of worksheet by a specific hash algorithm [#1485](#1485) ### Fixed - Fix Chart samples by updating chart parameter from 0 to DataSeries::EMPTY_AS_GAP [#1448](#1448) - Fix return type in docblock for the Cells::get() [#1398](#1398) - Fix RATE, PRICE, XIRR, and XNPV Functions [#1456](#1456) - Save Excel 2010+ functions properly in XLSX [#1461](#1461) - Several improvements in HTML writer [#1464](#1464) - Fix incorrect behaviour when saving XLSX file with drawings [#1462](#1462), - Fix Crash while trying setting a cell the value "123456\n" [#1476](#1481) - Improved DATEDIF() function and reduced errors for Y and YM units [#1466](#1466) - Stricter typing for mergeCells [#1494](#1494) ### Changed - Drop support for PHP 7.1, according to https://phpspreadsheet.readthedocs.io/en/latest/#php-version-support - Drop partial migration tool in favor of complete migration via RectorPHP [#1445](#1445) - Limit composer package to `src/` [#1424](#1424)
BlackyTay
pushed a commit
to BlackyTay/PhpSpreadsheet
that referenced
this pull request
Aug 8, 2025
… with new line (PHPOffice#1481) * fix: issue PHPOffice#1476 crash with numeric string value terminating with new line * test: provided tests for issue PHPOffice#1476
BlackyTay
pushed a commit
to BlackyTay/PhpSpreadsheet
that referenced
this pull request
Aug 8, 2025
### Added - Support writing to streams in all writers [PHPOffice#1292](PHPOffice#1292) - Support CSV files with data wrapping a lot of lines [PHPOffice#1468](PHPOffice#1468) - Support protection of worksheet by a specific hash algorithm [PHPOffice#1485](PHPOffice#1485) ### Fixed - Fix Chart samples by updating chart parameter from 0 to DataSeries::EMPTY_AS_GAP [PHPOffice#1448](PHPOffice#1448) - Fix return type in docblock for the Cells::get() [PHPOffice#1398](PHPOffice#1398) - Fix RATE, PRICE, XIRR, and XNPV Functions [PHPOffice#1456](PHPOffice#1456) - Save Excel 2010+ functions properly in XLSX [PHPOffice#1461](PHPOffice#1461) - Several improvements in HTML writer [PHPOffice#1464](PHPOffice#1464) - Fix incorrect behaviour when saving XLSX file with drawings [PHPOffice#1462](PHPOffice#1462), - Fix Crash while trying setting a cell the value "123456\n" [PHPOffice#1476](PHPOffice#1481) - Improved DATEDIF() function and reduced errors for Y and YM units [PHPOffice#1466](PHPOffice#1466) - Stricter typing for mergeCells [PHPOffice#1494](PHPOffice#1494) ### Changed - Drop support for PHP 7.1, according to https://phpspreadsheet.readthedocs.io/en/latest/#php-version-support - Drop partial migration tool in favor of complete migration via RectorPHP [PHPOffice#1445](PHPOffice#1445) - Limit composer package to `src/` [PHPOffice#1424](PHPOffice#1424)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is:
Checklist:
Why this change is needed?
$worksheet->setCellValueByColumnAndRow(1,1,"123456\n");
Should add the value "123456\n" to the cell at indexes 1,1 but crashes because the DefaultValueBinder::dataTypeForValue matches (with the preg_match case) the value as a DataType::TYPE_NUMERIC and then the Cell->setValueExplicit crashes during the check if (is_string($pValue) && !is_numeric($pValue))
--
Thanks to Vagir-dev for help
Resolves #1476