Fix: emit OwnershipTransferred after updating owner (closes #51)#53
Merged
mudgen merged 2 commits intoOct 21, 2025
Merged
Conversation
maxnorm
approved these changes
Oct 20, 2025
adamgall
reviewed
Oct 20, 2025
Collaborator
|
You're not wrong for the extra gaz costs. Can storage update fail for some reasons? If not, i agree that the change is not needed |
JackieXu
pushed a commit
to JackieXu/Compose
that referenced
this pull request
Nov 6, 2025
…hip-event-order Fix: emit OwnershipTransferred after updating owner (closes Perfect-Abstractions#51)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the event emission order in ERC173 facet and library.
Details
OwnershipTransferredevent emission after updatingowner.Closes #51