Skip to content

Fix: emit OwnershipTransferred after updating owner (closes #51) #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mudgen merged 2 commits into from
Oct 21, 2025
Merged

Fix: emit OwnershipTransferred after updating owner (closes #51) #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e28d8d
Fix: emit OwnershipTransferred after updating owner (closes #51)
CodeCryptX Oct 20, 2025
bf0d340
Fix: emit OwnershipTransferred(LibERC173) after updating owner (close…
CodeCryptX Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/ERC173/ERC173.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@ contract ERC173Facet {
function transferOwnership(address _newOwner) external {
ERC173Storage storage s = getStorage();
if (msg.sender != s.owner) revert OwnableUnauthorizedAccount();
emit OwnershipTransferred(s.owner, _newOwner);
address previousOwner = s.owner;
s.owner = _newOwner;

emit OwnershipTransferred(previousOwner, _newOwner);
}
}
4 changes: 3 additions & 1 deletion src/ERC173/libraries/LibERC173.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@ library LibERC173 {
function transferOwnership(address _newOwner) internal {
ERC173Storage storage s = getStorage();
if (s.owner == address(0)) revert OwnableAlreadyRenounced();
emit OwnershipTransferred(s.owner, _newOwner);
address previousOwner = s.owner;
s.owner = _newOwner;

emit OwnershipTransferred(previousOwner, _newOwner);
}
}