Clang format gpu/segmentation#4819
Merged
kunaltyagi merged 5 commits intoAug 20, 2021
Merged
Conversation
kunaltyagi
requested changes
Jun 29, 2021
kunaltyagi
reviewed
Jul 2, 2021
| /* | ||
| if(tree_->cloud_.size() != host_cloud.size ()) | ||
| { | ||
| PCL_ERROR("[pcl::gpu::EuclideanClusterExtraction] size of host cloud and device |
Contributor
Author
There was a problem hiding this comment.
Him, this is a good question! This check seems to be active in the corresponding cpu method, but I am not sure this check is needed. I think constructing the tree with a superset of the pointcloud used for clustering should work. Nevertheless, I would prefer to activate it again in the GPU module for the sake of symmetry. What do you think?
| if(tree_->cloud_.size() != host_cloud.size ()) | ||
| { | ||
| PCL_ERROR("[pcl::gpu::EuclideanClusterExtraction] size of host cloud and device | ||
| cloud don't match!\n"); return; |
Contributor
Author
There was a problem hiding this comment.
see comment above above
Contributor
|
Add it to the script Line 11 in d242fcb |
Contributor
Author
|
Sorry for the long radio silence - I've been moving place. I added the the folder to the format.sh script. Thanks for pointing that out, @larshg ! |
larshg
approved these changes
Aug 9, 2021
kunaltyagi
approved these changes
Aug 20, 2021
Member
|
@mvieth Merge? 🚀 |
Member
|
No objections from my side |
mvieth
pushed a commit
to mvieth/pcl
that referenced
this pull request
Dec 27, 2021
* clang-format and some manual changes * second round of clang-format * corrected clang-format idiosyncrasies * corrected spelling mistake * added gpu/segmentation to format file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #4677 got merged, I wanted to do some summer cleaning (or winter cleaning if you read this from the southern hemisphere) in the segmentation codebase. I applied clang-format and did some manual modifications. Everything looks nice and shiny :-)