Fix null pathways when a naked throw is issued at the PSIC console#1629
Closed
JustinGrote wants to merge 1 commit intoPowerShell:masterfrom
JustinGrote:vscode/issue/3677
Closed
Fix null pathways when a naked throw is issued at the PSIC console#1629JustinGrote wants to merge 1 commit intoPowerShell:masterfrom JustinGrote:vscode/issue/3677
JustinGrote wants to merge 1 commit intoPowerShell:masterfrom
JustinGrote:vscode/issue/3677
Conversation
Collaborator
Author
|
Works as expected now, the color styling is another issue |
Member
|
@JustinGrote Did you mean to close this? |
Collaborator
Author
|
@andschwa I probably just deleted the branch during a cleanup accidentally, should still be valid. |
andyleejordan
approved these changes
Dec 27, 2021
Member
andyleejordan
left a comment
andyleejordan
left a comment
There was a problem hiding this comment.
Heh, I thought there would be more too this for some reason. Great and simple fix!
Member
|
@JustinGrote I'm going to see if I can get the old PowerShell context service tests online and add a regression test for this. |
Member
|
Ok, I enabled those tests! After they're merged I'll try to write a regression test for this (or you are free to take a stab at it) and then merge it. |
Member
|
Closing since I got this change in! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes PowerShell/vscode-powershell#3677