Enable PsesInternalHostTests (previously PowerShellContextTests)#1651
Merged
andyleejordan merged 5 commits intomasterfrom Jan 5, 2022
Merged
Enable PsesInternalHostTests (previously PowerShellContextTests)#1651andyleejordan merged 5 commits intomasterfrom
PsesInternalHostTests (previously PowerShellContextTests)#1651andyleejordan merged 5 commits intomasterfrom
Conversation
andyleejordan
added
Issue-Enhancement
andyleejordan
requested review from
JustinGrote,
SeeminglyScience,
daxian-dbw and
rjmholt
Member
Author
|
Oops, gotta fix it for Windows 🤷 |
andyleejordan
force-pushed
the
andschwa/pses-host-tests
branch
from
7c1a5cc to
cceedab
Compare
Member
Author
|
All fixed! |
Member
Author
|
Hey @JustinGrote I covered #1629 with a regression test and cherry-picked the commit. Can you review this? We can close the other PR. |
andyleejordan
force-pushed
the
andschwa/pses-host-tests
branch
from
c03154e to
76a5791
Compare
Collaborator
SeeminglyScience
left a comment
SeeminglyScience
left a comment
There was a problem hiding this comment.
LGTM! + one question
src/PowerShellEditorServices/Services/PowerShell/Host/PsesInternalHost.cs
Outdated
Show resolved
Hide resolved
andyleejordan
force-pushed
the
andschwa/pses-host-tests
branch
from
76a5791 to
0903b6a
Compare
Co-authored-by: Andy Schwartzmeyer <andrew@schwartzmeyer.com>
andyleejordan
force-pushed
the
andschwa/pses-host-tests
branch
from
0903b6a to
57bdb36
Compare
5 tasks
Member
Author
|
Part of #1677 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was fortunately able to re-enable the
PowerShellContextServicetests with the newPsesInternalHostpretty easily.Also fixes PowerShell/vscode-powershell#3677.