Edit payment option to work with ps_checkout#533
Merged
nicosomb merged 2 commits intoPrestaShop:developfrom Aug 4, 2023
Merged
Edit payment option to work with ps_checkout#533nicosomb merged 2 commits intoPrestaShop:developfrom
nicosomb merged 2 commits intoPrestaShop:developfrom
Conversation
kpodemski
requested changes
Jul 31, 2023
Contributor
kpodemski
left a comment
kpodemski
left a comment
There was a problem hiding this comment.
ps_checkout is not a native module, this is why the fix shouldn't be there
if changes in .tpl are valid for other payment methods, it's ok, but CSS rules shouldn't be part of Hummingbird
you can easily add it to your version of the theme, or contribute to ps_checkout to display correctly if the theme is Hummingbird
| @@ -0,0 +1,10 @@ | |||
| .payment__option { | |||
Contributor
There was a problem hiding this comment.
This shouldn't be inside core of Hummingbird but rather inside your theme or ps_checkout module :)
Contributor
Author
|
Hello @kpodemski ! |
kpodemski
approved these changes
Jul 31, 2023
Contributor
|
Thank you @tblivet ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not easy to test because the shop must have ps_checkout configure, but this should render the payment option like in the screen below : top -> before & bottom -> after 