Skip to content

Edit payment option to work with ps_checkout #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicosomb merged 2 commits into from
Aug 4, 2023
Merged

Edit payment option to work with ps_checkout #533

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bad22db
feat: edit payment option to work with ps_checkout
tblivet Jul 28, 2023
b743a1b
fix: remove ps_checkout specific rules
tblivet Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/scss/custom/modules/_checkout.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
.payment__option {
Copy link
Contributor

@kpodemski kpodemski Jul 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be inside core of Hummingbird but rather inside your theme or ps_checkout module :)

&.ps_checkout-payment-option{
label{
// Needed to override ps_checkout !important style
/* stylelint-disable-next-line declaration-no-important */
display: flex !important;
line-height: initial;
}
}
}
1 change: 1 addition & 0 deletions src/scss/custom/modules/_index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
@import "featuredproducts";
@import "checkout";
@import "contactform";
@import "contactinfo";
@import "emailsubscriptions";
Expand Down
19 changes: 9 additions & 10 deletions templates/checkout/_partials/steps/payment.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,23 +22,22 @@
{foreach from=$module_options item="option"}
<div id="{$option.id}-container" class="payment__option">
{* This is the way an option should be selected when Javascript is enabled *}
<label class="form-check-label mb-2">
<label class="form-check-label mb-3 d-flex align-items-center">
<input
class="form-check-input ps-shown-by-js me-1{if $option.binary} binary{/if}"
class="form-check-input ps-shown-by-js flex-shrink-0 my-0 me-2{if $option.binary} binary{/if}"
type="radio"
name="payment-option"
data-module-name="{$option.module_name}"
id="{$option.id}"
{if ($selected_payment_option == $option.id || $is_free) || ($payment_options|@count === 1 && $module_options|@count === 1)} checked {/if}
/>

<i class="form-check-round"></i>

{if $option.logo}
<img src="{$option.logo}" loading="lazy">
{/if}

{$option.call_to_action_text}

<span class="d-flex flex-wrap gap-1 align-items-center flex-grow-1">
{$option.call_to_action_text}
{if $option.logo}
<img class="flex-shrink-0" src="{$option.logo}" loading="lazy">
{/if}
</span>
</label>

{* This is the way an option should be selected when Javascript is disabled *}
Expand Down