Update configuration and add explicit configuration in hooks#907
Update configuration and add explicit configuration in hooks#907tblivet merged 8 commits intoPrestaShop:developfrom
Conversation
tblivet
commented
Jan 22, 2026
tblivet
commented
| Questions | Answers |
|---|---|
| Description? | Update configuration and add explicit configuration in hooks inpired by @jolelievre PR 👍 |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | -- |
| Sponsor company | @PrestaShopCorp |
| How to test? | -- |
config/theme.yml
Outdated
| compatibility: | ||
| from: 9.0.0 | ||
| from: 9.1.0 | ||
| to: ~ |
config/theme.yml
Outdated
| compatibility: | ||
| from: 9.1.0 | ||
| to: ~ | ||
| to: ^9.1.0 |
There was a problem hiding this comment.
Im' not sure the core is able to understand this format 🤔
There was a problem hiding this comment.
Currently, it seems that this field is not used at all. In any case, @ga-devfront and I think it would be better to introduce this rather than having no version limit. What do you think?
There was a problem hiding this comment.
Yeah, I was searching where it's checked, and its seems like it's never used...
There was a problem hiding this comment.
We can but it means we'll have to update it for 10.0 Which gives us some time 😅
There was a problem hiding this comment.
Yes, we will need to update this for v10. Hopefully, in the future, we will use Composer for this 👍
So, do you think we should just use to: 9.1.x or to: 9.1.99 at the moment ?
There was a problem hiding this comment.
You could use ~9.1.0 if you want to limit to >= 9.1.0 and < 9.2.0 But I think it's ok, I believe you already planned a future major version anyway no? So this will probably evolve
Besides, the core doesn't even check this field anyway 😅
| - ps_brandlist | ||
| - ps_supplierlist |
There was a problem hiding this comment.
Why are these two modules disabled as well? They were working fine, the UI tests were green on ps_supplierlist at least (I didn't work on the other, so I don't know about the other one but it probably works as well)
There was a problem hiding this comment.
In fact, they are working correctly, but they are disabled simply for design purposes and because they don’t bring much value for merchants, who most of the time don’t use them.
@Hlavtox, do you have an opinion on the use of these modules?
There was a problem hiding this comment.
Ok for me @Progi1984 it means you'll probably have to adapt the tests for these two modules by forcing them to be enabled
There was a problem hiding this comment.
I spoke about this with him and will do the same as for the wishlist 👍
There was a problem hiding this comment.
@tblivet ps_supplierlist is 100% out of the picture, I don’t know anybody who would use suppliers in FO, it's an internal thing. Why should anyone know your suppliers, to open the same shop? 🤣
Regarding the brand list - could be used, but since it's a left column module and we already have a brand filter in faceted search, also no value. No merchant in my case.
However! If the module displayed brand logos nicely on displayHome, then it would be a different story, would be cool. 😎
There was a problem hiding this comment.
Thank you @Hlavtox, I share the exact same point of view.
Reworking the module to feature brand logos on the homepage sounds like a great idea to me 👍
There was a problem hiding this comment.
@tblivet Cool, it would be a great addition, and it would not be difficult to do. :-)
I have a custom module for it. Either a custom list of manufacturers, alphabetically, or from most popular. https://eshop.agrola.cz/
There was a problem hiding this comment.
yeah it would be nice, especially because the brand page link is not displayed by default, not even in the footer
There was a problem hiding this comment.
you need to go to the sitemap to find it
ingridusta
left a comment
ingridusta
left a comment
There was a problem hiding this comment.
Hi @tblivet 🤗,
I tested your pr and it works perfectly :
-
Hummingbird theme installs correctly
-
On the contact page, contact infos appear only in the left column :
- The Brand List and Supplier List module are disabled and not displayed on categorie pages (also sub categories) :
- The Viewed Products module and Category Products display only 4 products :
Np regression detected on hummingbird theme.
It's QA approved 🔥
|
PR merged, well done! Message to @PrestaShop/committers: do not forget to milestone it before the merge. |
6 participants
