Skip to content

Update configuration and add explicit configuration in hooks #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tblivet merged 8 commits into from
Jan 26, 2026
Merged

Update configuration and add explicit configuration in hooks #907

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
251ee55
feat: configuration update
tblivet Jan 21, 2026
074187b
chore: readme
tblivet Jan 22, 2026
2b6ec58
feat: update modules configuration settings
tblivet Jan 22, 2026
0f50c1d
feat: hook emailalerts
tblivet Jan 22, 2026
5a0431b
feat: hook ps_viewedproduct
tblivet Jan 22, 2026
70af3b0
feat: update compatibility range
tblivet Jan 23, 2026
0eb342e
feat: update compatibility
tblivet Jan 23, 2026
9f79a2e
feat: add 2 modules
tblivet Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
# Hummingbird Theme for PrestaShop

![CI](https://github.com/PrestaShop/hummingbird/actions/workflows/lint.yml/badge.svg)
![PrestaShop 9.0+](https://img.shields.io/badge/prestashop-9.0%2B-brightgreen.svg)
![PrestaShop 9.1+](https://img.shields.io/badge/prestashop-9.1%2B-brightgreen.svg)
![Docker Ready](https://img.shields.io/badge/docker-ready-blue.svg)
![Node.js v20](https://img.shields.io/badge/node.js-20.x-blue.svg)
![License](https://img.shields.io/badge/license-AFL%203.0-lightgray.svg)

Hummingbird is a modern, in-development theme for PrestaShop built to be compatible with versions `9.0.x` and above.
Hummingbird is a modern, in-development theme for PrestaShop built to be compatible with versions `9.1.x` and above.

## 🔍 Theme Previews

Expand Down
55 changes: 41 additions & 14 deletions config/theme.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ author:

meta:
compatibility:
from: 9.0.0
to: ~
from: 9.1.0
to: ~9.1.0
framework: bootstrap-v5.3.3

available_layouts:
Expand All @@ -33,17 +33,24 @@ global_settings:
NEW_PRODUCTS_NBR: 4
BLOCKSPECIALS_SPECIALS_NBR: 4
PS_BLOCK_BESTSELLERS_TO_DISPLAY: 4
PRODUCTS_VIEWED_NBR: 4
CATEGORYPRODUCTS_DISPLAY_PRODUCTS: 4
PSR_ICON_COLOR: "#0b69f6"
PSR_TEXT_COLOR: "#212529"
modules:
to_enable:
- ps_linklist
to_disable:
- blockwishlist
- ps_brandlist
- ps_supplierlist
Comment on lines +43 to +44
Copy link
Contributor

@jolelievre jolelievre Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these two modules disabled as well? They were working fine, the UI tests were green on ps_supplierlist at least (I didn't work on the other, so I don't know about the other one but it probably works as well)

Copy link
Contributor Author

@tblivet tblivet Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, they are working correctly, but they are disabled simply for design purposes and because they don’t bring much value for merchants, who most of the time don’t use them.

@Hlavtox, do you have an opinion on the use of these modules?

Copy link
Contributor

@jolelievre jolelievre Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me @Progi1984 it means you'll probably have to adapt the tests for these two modules by forcing them to be enabled

Copy link
Contributor Author

@tblivet tblivet Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spoke about this with him and will do the same as for the wishlist 👍

Copy link
Contributor

@Hlavtox Hlavtox Jan 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tblivet ps_supplierlist is 100% out of the picture, I don’t know anybody who would use suppliers in FO, it's an internal thing. Why should anyone know your suppliers, to open the same shop? 🤣

Regarding the brand list - could be used, but since it's a left column module and we already have a brand filter in faceted search, also no value. No merchant in my case.

However! If the module displayed brand logos nicely on displayHome, then it would be a different story, would be cool. 😎

Copy link
Contributor Author

@tblivet tblivet Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Hlavtox, I share the exact same point of view.
Reworking the module to feature brand logos on the homepage sounds like a great idea to me 👍

Copy link
Contributor

@Hlavtox Hlavtox Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tblivet Cool, it would be a great addition, and it would not be difficult to do. :-)

I have a custom module for it. Either a custom list of manufacturers, alphabetically, or from most popular. https://eshop.agrola.cz/

Copy link
Contributor

@jolelievre jolelievre Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it would be nice, especially because the brand page link is not displayed by default, not even in the footer

Copy link
Contributor

@jolelievre jolelievre Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to go to the sitemap to find it

hooks:
modules_to_unhook:
displayFooter:
- ps_socialfollow
displaySearch:
- ps_searchbar
modules_to_hook:
displayCustomerAccount:
- psgdpr
displayAfterBodyOpeningTag:
- blockreassurance
# Keep existing hooks and append them after
- ~
displayNav1:
Expand All @@ -57,6 +64,10 @@ global_settings:
- ps_shoppingcart
# Keep existing hooks and append them after
- ~
displayNavFullWidth:
- blockreassurance
# Keep existing hooks and append them after
- ~
displayTop:
- ps_mainmenu
- ps_searchbar
Expand All @@ -74,6 +85,7 @@ global_settings:
displayFooterBefore:
- ps_socialfollow
- ps_emailsubscription
- blockreassurance
# Keep existing hooks and append them after
- ~
displayFooter:
Expand All @@ -82,8 +94,8 @@ global_settings:
- ps_contactinfo
# Keep existing hooks and append them after
- ~
displayFooterProduct:
- productcomments
displayFooterAfter:
- blockreassurance
# Keep existing hooks and append them after
- ~
displayLeftColumn:
Expand All @@ -103,27 +115,42 @@ global_settings:
- contactform
# Keep existing hooks and append them after
- ~
displaySearch:
- ps_searchbar
# Keep existing hooks and append them after
- ~
displayProductAdditionalInfo:
- ps_sharebuttons
- productcomments
- ps_emailalerts
- ps_viewedproduct
# Keep existing hooks and append them after
- ~
displayProductListReviews:
- productcomments
# Keep existing hooks and append them after
- ~
displayOrderConfirmation2:
- ps_featuredproducts
displayFooterProduct:
- productcomments
# Keep existing hooks and append them after
- ~
displayCrossSellingShoppingCart:
- ps_featuredproducts
# Keep existing hooks and append them after
- ~
displayOrderConfirmation2:
- ps_featuredproducts
# Keep existing hooks and append them after
- ~
displayReassurance:
- blockreassurance
# Keep existing hooks and append them after
- ~
displayCustomerAccount:
- ps_emailalerts
- psgdpr
# Keep existing hooks and append them after
- ~
displayGDPRConsent:
- psgdpr
# Keep existing hooks and append them after
- ~

image_types:
cart_default:
Expand Down