fix: allow default message to be displayed if psData is not set in usePasswordPolicy#941
Merged
tblivet merged 1 commit intoPrestaShop:2.xfrom Mar 4, 2026
Merged
Conversation
Contributor
aeyoll
commented
Feb 27, 2026
aeyoll
commented
| Questions | Answers |
|---|---|
| Description? | An OR operator was used, but with the left side expression being always true, so the default message could never be displayed. |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | na |
|
Hello @aeyoll! This is your first pull request on hummingbird repository of the PrestaShop project. Thank you, and welcome to this Open Source community! |
aeyoll
force-pushed
the
fix-error-message
branch
2 times, most recently
from
b587125 to
b0e4889
Compare
aeyoll
force-pushed
the
fix-error-message
branch
2 times, most recently
from
b05fe2b to
3e96f9b
Compare
aeyoll
force-pushed
the
fix-error-message
branch
from
3e96f9b to
b0beb4c
Compare
aeyoll
force-pushed
the
fix-error-message
branch
from
b0beb4c to
2ed2c64
Compare
tblivet
approved these changes
Feb 27, 2026
ingridusta
approved these changes
Mar 3, 2026
ingridusta
left a comment
ingridusta
left a comment
There was a problem hiding this comment.
Hi @aeyoll,
Thanks for your PR !
No regression on password field and error messages are well displayed :
Also, no regression on account creation.
It's QA approved ! ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.