Skip to content

fix: allow default message to be displayed if psData is not set in usePasswordPolicy #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tblivet merged 1 commit into from
Mar 4, 2026
Merged

fix: allow default message to be displayed if psData is not set in usePasswordPolicy #941

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/js/components/usePasswordPolicy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,10 @@ const buildValidationMessage = (
// Get base message
if (!lengthValid) {
const invalidElement = feedbackContainer.querySelector(PasswordPolicyMap.lengthMessage) as HTMLElement;
message = `${invalidElement?.dataset?.psData}\n` || 'Your password length is invalid \n';
message = `${invalidElement?.dataset?.psData || 'Your password length is invalid'}\n`;
} else if (!strengthValid) {
const invalidElement = feedbackContainer.querySelector(PasswordPolicyMap.invalidMessage) as HTMLElement;
message = `${invalidElement?.dataset?.psData}\n` || 'Your password is too weak \n';
message = `${invalidElement?.dataset?.psData || 'Your password is too weak'}\n`;
}

// Get hints suggestions
Expand Down