Mark ControlUtil.deadband deprecated. Turns out, there is an equivale…#78
Merged
Conversation
…nt function in the edu.wpi.first libraries
Contributor
Author
|
Thanks, @spderman3333 ! |
kcooney
added a commit
to Prospect-Robotics/Robot2025
that referenced
this pull request
Oct 15, 2025
This includes the following: - Prospect-Robotics/lib2813#46 - Prospect-Robotics/lib2813#67 - Prospect-Robotics/lib2813#71 - Prospect-Robotics/lib2813#75 - Prospect-Robotics/lib2813#77 - Prospect-Robotics/lib2813#78 - Prospect-Robotics/lib2813#80 - Prospect-Robotics/lib2813#81 - Prospect-Robotics/lib2813#85
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nt function in the edu.wpi.first libraries
Our unit-tests for this function pass, which confirms that edu.wpi.first.math.MathUtil.applyDeadband is a drop in replacement, minus the exceptions our functions throw when its parameters are out of range.
In practice, we probably don't need these checks anyway, since values outside of [-1, 1] cannot come from controllers.