Skip to content

Force non-positional control for the MotorSubsystem ControlMode#84

Merged
cuttestkittensrule merged 1 commit into
mainfrom
kyle/force-non-positional-control-for-motor-subsystem
Oct 15, 2025
Merged

Force non-positional control for the MotorSubsystem ControlMode#84
cuttestkittensrule merged 1 commit into
mainfrom
kyle/force-non-positional-control-for-motor-subsystem

Conversation

@cuttestkittensrule
Copy link
Copy Markdown
Collaborator

@cuttestkittensrule cuttestkittensrule commented Oct 14, 2025

Achieved by throwing an exception if the control mode uses positional control.
Also removes unused ControlMode API.

@kcooney
Copy link
Copy Markdown
Contributor

kcooney commented Oct 15, 2025

@cuttestkittensrule you need to rebase or merge from main to pick up #85 to fix the compile error

Copy link
Copy Markdown
Member

@spderman3333 spderman3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still not too sure what exactly passing a positional motor control would do, will trace the code.

Achieved by throwing an exception if the control mode uses positional control

also removes unused ControlMode API
@cuttestkittensrule cuttestkittensrule force-pushed the kyle/force-non-positional-control-for-motor-subsystem branch from e17f571 to aac74cf Compare October 15, 2025 15:54
@cuttestkittensrule cuttestkittensrule merged commit 1cacfb0 into main Oct 15, 2025
1 check passed
@cuttestkittensrule cuttestkittensrule deleted the kyle/force-non-positional-control-for-motor-subsystem branch October 15, 2025 17:19
@spderman3333 spderman3333 linked an issue Oct 18, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MotorSubsystem is a wrapper over positional motor control.

3 participants