Skip to content

fix typo - #850

Closed
oh5221 wants to merge 1 commit into
PyTorchKR:masterfrom
oh5221:suyeon-fix
Closed

fix typo#850
oh5221 wants to merge 1 commit into
PyTorchKR:masterfrom
oh5221:suyeon-fix

Conversation

@oh5221

@oh5221 oh5221 commented Aug 11, 2024

Copy link
Copy Markdown
Contributor

๋ผ์ด์„ ์Šค ๋™์˜

๋ณ€๊ฒฝํ•ด์ฃผ์‹œ๋Š” ๋‚ด์šฉ์— BSD 3ํ•ญ ๋ผ์ด์„ ์Šค๊ฐ€ ์ ์šฉ๋จ์„ ๋™์˜ํ•ด์ฃผ์…”์•ผ ํ•ฉ๋‹ˆ๋‹ค.

๋” ์ž์„ธํ•œ ๋‚ด์šฉ์€ ๊ธฐ์—ฌํ•˜๊ธฐ ๋ฌธ์„œ๋ฅผ ์ฐธ๊ณ ํ•ด์ฃผ์„ธ์š”.

๋™์˜ํ•˜์‹œ๋ฉด ์•„๋ž˜ [ ]๋ฅผ [x]๋กœ ๋งŒ๋“ค์–ด์ฃผ์„ธ์š”.

  • ๊ธฐ์—ฌํ•˜๊ธฐ ๋ฌธ์„œ๋ฅผ ํ™•์ธํ•˜์˜€์œผ๋ฉฐ, ๋ณธ PR ๋‚ด์šฉ์— BSD 3ํ•ญ ๋ผ์ด์„ ์Šค๊ฐ€ ์ ์šฉ๋จ์— ๋™์˜ํ•ฉ๋‹ˆ๋‹ค.

๊ด€๋ จ ์ด์Šˆ ๋ฒˆํ˜ธ

์ด Pull Request์™€ ๊ด€๋ จ์žˆ๋Š” ์ด์Šˆ ๋ฒˆํ˜ธ๋ฅผ ์ ์–ด์ฃผ์„ธ์š”.

์ด์Šˆ ๋˜๋Š” PR ๋ฒˆํ˜ธ ์•ž์— #์„ ๋ถ™์ด์‹œ๋ฉด ์ œ๋ชฉ์„ ๋ฐ”๋กœ ํ™•์ธํ•˜์‹ค ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค. (์˜ˆ. #999 )

PR ์ข…๋ฅ˜

์ด PR์— ํ•ด๋‹น๋˜๋Š” ์ข…๋ฅ˜ ์•ž์˜ [ ]์„ [x]๋กœ ๋ณ€๊ฒฝํ•ด์ฃผ์„ธ์š”.

  • ์˜คํƒˆ์ž๋ฅผ ์ˆ˜์ •ํ•˜๊ฑฐ๋‚˜ ๋ฒˆ์—ญ์„ ๊ฐœ์„ ํ•˜๋Š” ๊ธฐ์—ฌ
  • ๋ฒˆ์—ญ๋˜์ง€ ์•Š์€ ํŠœํ† ๋ฆฌ์–ผ์„ ๋ฒˆ์—ญํ•˜๋Š” ๊ธฐ์—ฌ
  • ๊ณต์‹ ํŠœํ† ๋ฆฌ์–ผ ๋‚ด์šฉ์„ ๋ฐ˜์˜ํ•˜๋Š” ๊ธฐ์—ฌ
  • ์œ„ ์ข…๋ฅ˜์— ํฌํ•จ๋˜์ง€ ์•Š๋Š” ๊ธฐ์—ฌ

PR ์„ค๋ช…

์ด PR๋กœ ๋ฌด์—‡์ด ๋‹ฌ๋ผ์ง€๋Š”์ง€ ๋Œ€๋žต์ ์œผ๋กœ ์•Œ๋ ค์ฃผ์„ธ์š”.
parallelism_tutorial.py์—์„œ ๋ฏธ๋‹ˆ-๋ฐฐ์น˜์™€ ๋ฏธ๋‹ˆ๋ฐฐ์น˜ ํ†ต์ผ

Intro_to_TorchScript_tutorial.py์˜ 117๋ฒˆ ์ค„์—์„œ "์š”์ปจ๋ฐ"๋ฅผ "์š”์ปจ๋Œ€"๋กœ ์ˆ˜์ •

@Angela-Park-JE Angela-Park-JE left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋งค์˜ ๋ˆˆ์œผ๋กœ ์ฐพ์•„๋‚ด์…จ๋„ค์š”! ์ˆ˜๊ณ ํ•˜์…จ์Šต๋‹ˆ๋‹ค ๐Ÿ˜†๐Ÿ‘

@hyoyoung hyoyoung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋‚ด์šฉ ์ž์ฒด๋Š” ์ข‹์œผ๋‚˜ mergeํ•˜๊ธฐ๋Š” ์–ด๋ ค์šด PR์ž…๋‹ˆ๋‹ค

  1. ๋ผ์ด์„ผ์Šค ๋™์˜ ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค
  2. ์„œ๋กœ ๋‹ค๋ฅธ ํŒŒ์ผ์ด๋ฏ€๋กœ ๊ฐ€๊ธ‰์  PR์„ ๋‚˜๋ˆ ์„œ ๋ณด๋‚ด์ฃผ์‹œ๋ฉด ๋” ์ข‹๊ฒ ์Šต๋‹ˆ๋‹ค

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants