Skip to content

Fix typo part1: Intro to TorchScript Tutorial - #880

Closed
oh5221 wants to merge 2 commits into
PyTorchKR:masterfrom
oh5221:fix-typo-part1
Closed

Fix typo part1: Intro to TorchScript Tutorial#880
oh5221 wants to merge 2 commits into
PyTorchKR:masterfrom
oh5221:fix-typo-part1

Conversation

@oh5221

@oh5221 oh5221 commented Aug 21, 2024

Copy link
Copy Markdown
Contributor

๋ผ์ด์„ ์Šค ๋™์˜

๋ณ€๊ฒฝํ•ด์ฃผ์‹œ๋Š” ๋‚ด์šฉ์— BSD 3ํ•ญ ๋ผ์ด์„ ์Šค๊ฐ€ ์ ์šฉ๋จ์„ ๋™์˜ํ•ด์ฃผ์…”์•ผ ํ•ฉ๋‹ˆ๋‹ค.

๋” ์ž์„ธํ•œ ๋‚ด์šฉ์€ ๊ธฐ์—ฌํ•˜๊ธฐ ๋ฌธ์„œ๋ฅผ ์ฐธ๊ณ ํ•ด์ฃผ์„ธ์š”.

๋™์˜ํ•˜์‹œ๋ฉด ์•„๋ž˜ [ ]๋ฅผ [x]๋กœ ๋งŒ๋“ค์–ด์ฃผ์„ธ์š”.

  • ๊ธฐ์—ฌํ•˜๊ธฐ ๋ฌธ์„œ๋ฅผ ํ™•์ธํ•˜์˜€์œผ๋ฉฐ, ๋ณธ PR ๋‚ด์šฉ์— BSD 3ํ•ญ ๋ผ์ด์„ ์Šค๊ฐ€ ์ ์šฉ๋จ์— ๋™์˜ํ•ฉ๋‹ˆ๋‹ค.

๊ด€๋ จ ์ด์Šˆ ๋ฒˆํ˜ธ

์ด Pull Request์™€ ๊ด€๋ จ์žˆ๋Š” ์ด์Šˆ ๋ฒˆํ˜ธ๋ฅผ ์ ์–ด์ฃผ์„ธ์š”.

์ด์Šˆ ๋˜๋Š” PR ๋ฒˆํ˜ธ ์•ž์— #์„ ๋ถ™์ด์‹œ๋ฉด ์ œ๋ชฉ์„ ๋ฐ”๋กœ ํ™•์ธํ•˜์‹ค ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค. (์˜ˆ. #999 )

PR ์ข…๋ฅ˜

์ด PR์— ํ•ด๋‹น๋˜๋Š” ์ข…๋ฅ˜ ์•ž์˜ [ ]์„ [x]๋กœ ๋ณ€๊ฒฝํ•ด์ฃผ์„ธ์š”.

  • ์˜คํƒˆ์ž๋ฅผ ์ˆ˜์ •ํ•˜๊ฑฐ๋‚˜ ๋ฒˆ์—ญ์„ ๊ฐœ์„ ํ•˜๋Š” ๊ธฐ์—ฌ
  • ๋ฒˆ์—ญ๋˜์ง€ ์•Š์€ ํŠœํ† ๋ฆฌ์–ผ์„ ๋ฒˆ์—ญํ•˜๋Š” ๊ธฐ์—ฌ
  • ๊ณต์‹ ํŠœํ† ๋ฆฌ์–ผ ๋‚ด์šฉ์„ ๋ฐ˜์˜ํ•˜๋Š” ๊ธฐ์—ฌ
  • ์œ„ ์ข…๋ฅ˜์— ํฌํ•จ๋˜์ง€ ์•Š๋Š” ๊ธฐ์—ฌ

PR ์„ค๋ช…

์ด PR๋กœ ๋ฌด์—‡์ด ๋‹ฌ๋ผ์ง€๋Š”์ง€ ๋Œ€๋žต์ ์œผ๋กœ ์•Œ๋ ค์ฃผ์„ธ์š”.

  • ๊ธฐ์กด์˜ PR fix typoย #850 ์—์„œ ๋‘ ๊ฐ€์ง€ ํŒŒ์ผ์„ ํ•œ๋ฒˆ์— ์˜ฌ๋ ธ๊ธฐ ๋•Œ๋ฌธ์—, commit์ด ์šฉ์ดํ•˜๊ฒŒ๋” ๋‚˜๋ˆ„์–ด ๋‹ค์‹œ PRํ–ˆ์Šต๋‹ˆ๋‹ค.
  • Intro_to_TorchScript_tutorial.py์˜ 117๋ฒˆ ์ค„์—์„œ "์š”์ปจ๋ฐ"๋ฅผ "์š”์ปจ๋Œ€"๋กœ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.

@oh5221 oh5221 changed the title Fix typo part1 Fix typo part1: Intro to TorchScript Tutorial Aug 21, 2024
@oh5221

oh5221 commented Aug 21, 2024

Copy link
Copy Markdown
Contributor Author

์˜ฌ๋ฆฌ๊ณ  ๋‚˜์„œ ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค ์ฃ„์†กํ•ฉ๋‹ˆ๋‹ค...
์ˆ˜์ •์„ ์œ„ํ•ด ๋‹ค๋ฅธ ๋ธŒ๋žœ์น˜์—์„œ ํŒŒ์ผ ํ•˜๋‚˜๋งŒ addํ•ด์„œ commitํ–ˆ๋Š”๋ฐ ์ด๋ฒˆ์—๋„ ๋‘ ๊ฐ€์ง€ ํŒŒ์ผ์ด ํฌํ•จ๋˜์–ด ์žˆ๋Š” ์ด์œ ๋ฅผ ๋ชจ๋ฅด๊ฒ ์Šต๋‹ˆ๋‹ค...ใ… ใ… 

@oh5221 oh5221 closed this Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant