Nightly/release: build only shipped binaries + fix draft-staging cleanup - #28
Merged
Conversation
volen-silo
changed the title
juhovainio
approved these changes
Jun 18, 2026
The nightly/release build steps ran `cargo build --release --workspace`, compiling the full workspace in release mode inside manylinux — including the standalone rocm-engine-* binaries and rocm-dash-daemon that are no longer shipped (the bundle is rocm + rocmd), plus all test/example targets. Narrow the build to the binaries that are actually packaged plus the signing tool: `cargo build --release -p rocm -p rocmd -p xtask`. The engine library crates still compile (they are linked into rocm for the in-process engines), so behavior is unchanged; we just skip the redundant binary link/codegen steps. Full-workspace compilation remains covered by ci.yml's build-and-test.
publish-nightly ended with `gh release delete "$STAGING_TAG" --yes --cleanup-tag`, which failed the job with HTTP 422 "Reference does not exist": the staging release is created as a --draft, and draft releases never create a git tag, so there is nothing for --cleanup-tag to delete. The rolling `nightly` release and all assets had already been published successfully; only this final cleanup line failed. Drop --cleanup-tag (delete just the draft) and tolerate errors, matching the other two staging-delete sites.
volen-silo
force-pushed
the
nightly-build-only-shipped
branch
from
June 18, 2026 13:54
450747c to
b4523d7
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two nightly/release packaging fixes.
1. Build only shipped binaries (speed up)
The build steps ran
cargo build --release --workspace, compiling the whole workspace in release mode inside manylinux — including the six standalonerocm-engine-*binaries androcm-dash-daemonthat are no longer shipped (bundle isrocm+rocmd), plus test/example targets. Narrowed to:Engine library crates still compile (linked into
rocmfor the in-process engines), so behavior is unchanged; we skip the redundant binary link/codegen. Full-workspace compilation stays covered byci.yml'sbuild-and-test. (nightly.yml + release.yml, Linux + Windows.)2. Fix
publish-nightlyfailing on staging cleanupThe first fully-working nightly published the rolling
nightlyrelease with all 16 assets, then the job failed on its last line:gh release delete "$STAGING_TAG" --yes --cleanup-tag422s because the staging release is a--draft, and draft releases never create a git tag — so there's nothing for--cleanup-tagto delete. Dropped--cleanup-tagand made it tolerant, matching the other two staging-delete sites. (release.ymldoesn't have this pattern — it publishes via--draft=false.)Status
The convenience-asset + signing pipeline is otherwise working end-to-end — the latest manual nightly already produced a healthy
nightlyrelease (signed bundles +rocm/rocm.exe/linux-binaries.tar.gz/windows-binaries.zip). This PR just makes the run go fully green and trims build time.