Skip to content

Nightly/release: build only shipped binaries + fix draft-staging cleanup #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
volen-silo merged 2 commits into from
Jun 18, 2026
Merged

Nightly/release: build only shipped binaries + fix draft-staging cleanup #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a88671d
Build only shipped binaries in nightly/release (speed up)
volen-silo Jun 18, 2026
b4523d7
Fix nightly publish: don't --cleanup-tag the draft staging release
volen-silo Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ jobs:
curl -fsSL https://sh.rustup.rs | sh -s -- -y --profile minimal --default-toolchain none --no-modify-path
fi
export PATH="/host-cargo/bin:$PATH"
cargo build --release --workspace
cargo build --release -p rocm -p rocmd -p xtask
'

- name: Set nightly metadata
Expand Down Expand Up @@ -184,7 +184,7 @@ jobs:

- name: Build release binaries
shell: pwsh
run: cargo build --release --workspace
run: cargo build --release -p rocm -p rocmd -p xtask

- name: Package Windows bundle
shell: pwsh
Expand Down Expand Up @@ -292,7 +292,9 @@ jobs:
"${EXTRA}/rocm" "${EXTRA}/rocm.exe" \
"${EXTRA}/linux-binaries.tar.gz" "${EXTRA}/windows-binaries.zip" --clobber

gh release delete "${STAGING_TAG}" --yes --cleanup-tag
# The staging release is a draft, which never creates a git tag, so
# --cleanup-tag would 422 on a nonexistent ref. Just delete the draft.
gh release delete "${STAGING_TAG}" --yes 2>/dev/null || true

cleanup-staging-nightly:
name: Clean failed nightly staging release
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ jobs:
curl -fsSL https://sh.rustup.rs | sh -s -- -y --profile minimal --default-toolchain none --no-modify-path
fi
export PATH="/host-cargo/bin:$PATH"
cargo build --release --workspace
cargo build --release -p rocm -p rocmd -p xtask
'

- name: Package release bundle
Expand Down Expand Up @@ -168,7 +168,7 @@ jobs:

- name: Build release binaries
shell: pwsh
run: cargo build --release --workspace
run: cargo build --release -p rocm -p rocmd -p xtask

- name: Package Windows bundle
shell: pwsh
Expand Down
Loading