Speed up CI - #5
Closed
r0x0r wants to merge 2 commits into
Closed
Conversation
build-vendored-codex.sh: when ROCM_CODEX_PREBUILT_BINARY is set, copy the prebuilt binary directly instead of running a full Cargo build of the vendored Codex workspace. acceptance script: after the release build completes, export ROCM_CODEX_PREBUILT_BINARY pointing at target/release/rocm-codex so that the packaging step reuses the binary already on disk instead of triggering a second multi-minute cold compile with separate dependency downloads. ci.yml: on push builds, run the release build + codex once before the acceptance step so the prebuilt binary is warm in the cache.
Collaborator
|
Superseded by dropping the vendored Codex tree entirely. Instead of prebuilding |
5 tasks
michaelroy-amd
added a commit
that referenced
this pull request
Jun 29, 2026
… scroll, doc fixes - #3: guard the Esc menu on a pure menu_fits() helper so it only renders when the logo AND all three items (Options/Help/Quit) fit; the old inner.height < 6 guard painted the logo with no reachable items at heights 6..=10. New unit test exercises the broken range + boundary. - #4: remove the dead 't theme' launcher footer hint (no t handler). - #5: global Help jump-to-tab now reads '1 .. 5' (5 tabs), matching draw_help. - #6: scroll-offset casts use u16::try_from(..).unwrap_or(u16::MAX) instead of 'as u16' (console v/h, dock logs, bench detail, chat) — no wrap >65535. - #7: split misattributed doc comments so apply_action and clamp_selectors each carry their own doc (and drop a stale gpu_scroll line). Signed-off-by: Michael Roy <michael.roy@amd.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request optimizes the CI pipeline and acceptance test workflow by reusing prebuilt release binaries, particularly the large
rocm-codexbinary, to avoid redundant compilation steps. It introduces environment variable handling and script logic to detect and use existing binaries, improving build efficiency and reducing CI runtime.CI/CD pipeline improvements:
.github/workflows/ci.ymlto pre-build release binaries and the vendored Codex binary during push events, making them available for later acceptance steps and reducing duplicate compilation.CARGO_TARGET_DIRenvironment variable in the CI workflow to ensure consistent target directory usage across steps.cargo buildsteps from both Linux and Windows jobs, as builds are now handled earlier or reused. [1] [2]Acceptance and packaging script enhancements:
scripts/acceptance-install-upgrade-tui-uninstall.shto resolve and export the location of the prebuiltrocm-codexbinary, enabling downstream scripts to reuse it if present.scripts/build-vendored-codex.shto support a fast path: if theROCM_CODEX_PREBUILT_BINARYenvironment variable is set and points to an existing binary, the script installs it directly instead of rebuilding, further reducing redundant builds in CI and local development.