Land #4 (prek hooks + flaky-test fixes + drop vendored Codex), rebased onto #1-3

[michaelroy-amd]

Lands PR #4 (prek-hooks: prek hooks + headless/flaky test fixes + drop vendored Codex) rebased onto current main (which already contains #1 lemonade-auto-backend, #2 native-certs, #3 uv-migration).

GitHub could not auto-rebase-merge the original #4 because it conflicted with #3, and main's branch protection (required signatures + reviews) blocks direct pushes — so #4's 12 commits were replayed locally onto main and the conflict resolved here. This PR squash-lands that resolved result; original #4 will be closed as landed.

Conflict resolution (verified, 3-agent refute panel clean)

• apps/rocm/src/main.rs — Migrate Python environment management from pip to uv #3 kept the vendored-Codex TUI block; Fix CI: prek hooks, headless/flaky test fixes, and drop vendored Codex #4 deletes it. Took Fix CI: prek hooks, headless/flaky test fixes, and drop vendored Codex #4: removed the vendored-Codex subgraph (render_codex_bridge_instructions, config_string_override/config_raw_override, codex_bridge_gpu_summary, nested_json_u64). The lightweight codex-bridge snapshot API (build_codex_bridge_snapshot / CodexBridgeSnapshot, rocmd-codex-bridge-v0) is kept — codex-grep output is byte-identical to Fix CI: prek hooks, headless/flaky test fixes, and drop vendored Codex #4's main.rs.
• scripts/therock_sdk_install_test.py — Migrate Python environment management from pip to uv #3 renamed install format pip→wheel; Fix CI: prek hooks, headless/flaky test fixes, and drop vendored Codex #4's delta was a ruff reformat that kept stale --format pip. Resolved to wheel in ruff's multi-line form. Also fixed a pre-existing Migrate Python environment management from pip to uv #3 syntax error on this file (a doubled quote != "wheel"": → != "wheel":) that Fix CI: prek hooks, headless/flaky test fixes, and drop vendored Codex #4's new ruff hook would otherwise reject. ruff format --check + ruff check clean; valid Python.

Validation

• cargo build --workspace --all-targets → exit 0
• cargo test --workspace -- --test-threads=1 → 0 failures (1068 passed). Fix CI: prek hooks, headless/flaky test fixes, and drop vendored Codex #4 fixes the 2 pre-existing therock python_launcher failures. The 2 remaining tui.rs failures under default parallel test are headless-contention flakes (pass in isolation) and are slated for removal when tui.rs is retired.
• cargo clippy --workspace → exit 0

Authorship of the 12 underlying commits is preserved as Roman Inflianskas (rominf).

[michaelroy-amd]

This will get things aligned to use rocm-dash-tui instead of tui.rs but it's not going to be feature-parity at this commit. Once properly rebased, I'll implement the remaining slash commands and other TUI work that was done.

[michaelroy-amd]

We need this PR reviewed so that it makes PR #4 merge cleanly against main.

Once reviewed and merged, we'll approve #4 and then we can get to re-implementing all the old tui.rs functionalinty.

[rominf]

Thanks for landing this, @michaelroy-amd — and especially for preserving authorship of the 12 underlying commits as me (Roman Inflianskas). Replaying them onto main rather than squashing them under a single name keeps the history honest; much appreciated.

I reviewed the CI-fix commit on top (b4dfb63, fix(ci): resolve clippy/fmt/windows-build-and-test failures). It looks clean and correctly scoped:

• clippy — format!("failed to launch uv") → .to_string(), the nested if let { if … } blocks collapsed into let-chains, and the Tab/BackTab/Up/Down arms collapsed into guard arms. All behavior-preserving; the let-chain form matches what's already used in uv.rs::find_binary_in.
• dead code — dropping the now-orphaned command_succeeds and write_fake_python_without_venv_support test helpers is the right call once their callers were removed.
• fmt — pure formatting churn, nothing semantic.
• windows test + smoke_local.py — the "Windows V1"→"Windows" and --format pip→--format wheel updates are correct realignments to #3's rename; these were genuine stale assertions.
• correctness — nice catch on the rocm-core legacy-ROCm hint still suggesting the invalid --format pip. That's a real user-facing string, so fixing it (and its test) is more than cosmetic.

The conflict-resolution writeup (keeping the codex-bridge snapshot API while dropping the vendored-Codex TUI subgraph, and the therock_sdk_install_test.py pip→wheel + doubled-quote syntax fix) all matches my intent for #4. LGTM.

[rominf]

Approving — see my review comment above. Authorship preservation and the b4dfb63 CI fix both LGTM. Thanks again, @michaelroy-amd.

[rominf]

Switching to request-changes — withdrawing my earlier approval.

The content is fine (see my detailed comment review above; authorship preservation and the b4dfb63 CI fix both LGTM). The blocker is commit signing: all 13 commits are unsigned.

$ git log -13 --format='%h %G? %an'
b4dfb63 N Michael Roy
f16db5c N Roman Inflianskas
... (all 13 show G? = N)

main's branch protection requires signed commits, so this won't satisfy the merge gate as-is. Could you re-sign and force-push the stack (e.g. git rebase --exec 'git commit --amend --no-edit -S' <base>, or -S on each)? Happy to re-approve once the commits verify — nothing else is blocking from my side.

[rominf]

Commits are signed now.