[rt-smart] kernel virtual memory management layer#6809
Merged
Conversation
Guozhanxin
reviewed
Jan 3, 2023
mysterywolf
reviewed
Jan 3, 2023
mysterywolf
reviewed
Jan 3, 2023
mysterywolf
reviewed
Jan 3, 2023
mysterywolf
requested changes
Jan 3, 2023
BernardXiong
requested changes
Jan 3, 2023
4891b5a to
2c528d4
Compare
Member
|
请将libc signal的这个问题单独抽出来提交一个PR,不要混在这个PR中 |
60a0c2f to
142464f
Compare
BernardXiong
requested changes
Jan 7, 2023
BernardXiong
approved these changes
Jan 7, 2023
mysterywolf
requested changes
Jan 7, 2023
mysterywolf
reviewed
Jan 8, 2023
9 tasks
mysterywolf
approved these changes
Jan 9, 2023
Member
|
CI 报错不用理 |
Guozhanxin
reviewed
Jan 9, 2023
Guozhanxin
approved these changes
Jan 9, 2023
Member
|
这个PR重新命名一下 标题名字太模糊了 写一下PR的描述 |
Contributor
Contributor
Author
|
I suppose SConscript should be replaced diff --git a/components/mm/SConscript b/components/mm/SConscript
index d6f78ee06..111da70f8 100644
--- a/components/mm/SConscript
+++ b/components/mm/SConscript
@@ -3,7 +3,7 @@ from building import *
objs = []
-if GetDepend('ARCH_MM_MMU'):
+if GetDepend('ARCH_ARM_CORTEX_A') or GetDepend('ARCH_ARMV8') or GetDepend('ARCH_RISCV64'):
cwd = GetCurrentDir()
src = Glob('*.c') + Glob('*_gcc.S')
CPPPATH = [cwd] |
Contributor
|
How about that? |
Contributor
Author
|
for the latest branch diff --git a/components/mm/SConscript b/components/mm/SConscript
index aee18c27c..725f097c0 100644
--- a/components/mm/SConscript
+++ b/components/mm/SConscript
@@ -3,7 +3,7 @@ from building import *
objs = []
-if GetDepend('ARCH_MM_MMU'):
+if GetDepend('ARCH_ARM_CORTEX_A') or GetDepend('ARCH_ARMV8') or GetDepend('ARCH_RISCV64'):
cwd = GetCurrentDir()
src = Glob('*.c') + Glob('*_gcc.S')
CPPPATH = [cwd] |
Contributor
Author
On armv7 armv8 and riscv64, the MM is enabled even without rt smart configured |
9 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
synchronize virtual memory system works.
你的解决方案是什么 (what is your solution)
在什么测试环境下测试通过 (what is the test environment)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up