Skip to content

Fix building issue of Nuvoton porting.#6833

Merged
Guozhanxin merged 3 commits into
RT-Thread:masterfrom
OpenNuvoton:lwip_priority_issue
Jan 11, 2023
Merged

Fix building issue of Nuvoton porting.#6833
Guozhanxin merged 3 commits into
RT-Thread:masterfrom
OpenNuvoton:lwip_priority_issue

Conversation

@wosayttn

@wosayttn wosayttn commented Jan 10, 2023

Copy link
Copy Markdown
Contributor

[

  1. Change thread priority of lwip-tcpip and erx.
  2. Remove '')' garbage symbols.
  3. mm driver issues.

#6815
#6809

NEED #6834
]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

1. Change thread priority of lwip-tcpip and erx.
2. Remove '')' garbage symbols.
3. mm driver issues.
@mysterywolf mysterywolf added the +1 Agree +1 label Jan 11, 2023
@Guozhanxin Guozhanxin added the +2 Agree +2 label Jan 11, 2023
@Guozhanxin Guozhanxin merged commit bf8db63 into RT-Thread:master Jan 11, 2023
@wosayttn wosayttn deleted the lwip_priority_issue branch January 11, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

+1 Agree +1 +2 Agree +2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants