[components][i2c] 优化 controt 接口格式，增加可用命令 by sp-cai · Pull Request #7806 · RT-Thread/rt-thread

sp-cai · 2023-07-10T04:54:17Z

拉取/合并请求描述：(PR description)

原来 rt_i2c_control 只能执行 RT_I2C_DEV_CTRL_CLK 单一命令，通过此修改可以支持更多可用命令

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

已经仔细查看过代码改动的对比 Already check the difference between PR and old code
代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
代码是高质量的 Code in this PR is of high quality
已经使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

由于 i2c_bus_control 的参数与系统标准的格式不同，不便于程序的扩展应用。

原来 rt_i2c_control 只能执行 RT_I2C_DEV_CTRL_CLK 命令，为了与系统此类函数的参数格式一致且更好的可扩展性。

增加 I2C 可用操作命令。

supperthomas

请问这个改动，需要bsp的driver配合修改吗？会涉及到所有bsp和example吗？

sp-cai · 2023-07-10T09:34:54Z

请问这个改动，需要bsp的driver配合修改吗？会涉及到所有bsp和example吗？

由于 bsp 和 example 太多，只抽检过部分，都没有影响的。

supperthomas · 2023-07-10T09:41:08Z

请问这个改动，需要bsp的driver配合修改吗？会涉及到所有bsp和example吗？

由于 bsp 和 example 太多，只抽检过部分，都没有影响的。

那你是基于那个bsp来进行测试的呢？

sp-cai · 2023-07-10T10:30:15Z

看过像 HC32、STM32、HK32、GD32 这些 BSP 都是用模拟 I2C 的，由于没有使用到，所以是没有影响的。检查现有 BSP 发现有部分如 ESP32_C3 的 I2C 虽然没有实际使用到，但是由于参数类型更改了会出现编译警告。声路电子科技有限公司蔡柳林电话：18575060827 ***@***.*** 网址：http://www.soundpath.com.cn 地址：广东省恩平市东安开发区江南四路铭达工业园A座三楼 2023-7-10 ---- 回复的原邮件 ---- | 发件人 | Supper ***@***.***> | | 发送日期 | 2023年7月10日 17:41 | | 收件人 | ***@***.***> | | 抄送人 | ***@***.***> , ***@***.***> | | 主题 | Re: [RT-Thread/rt-thread] [components][i2c] 优化 controt 接口格式，增加可用命令 (PR #7806) | 请问这个改动，需要bsp的driver配合修改吗？会涉及到所有bsp和example吗？由于 bsp 和 example 太多，只抽检过部分，都没有影响的。那你是基于那个bsp来进行测试的呢？ — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***>

supperthomas · 2023-07-10T11:12:37Z

嗯，这个改动是挺好的。所以我想问下你在哪个bsp上测试通过的？有没有一些example之类的。

sp-cai · 2023-07-10T12:39:46Z

嗯，这个改动是挺好的。所以我想问下你在哪个bsp上测试通过的？有没有一些example之类的。

HC32F460 使用自己写的 I2C 驱动，在项目开发中测试的

sp-cai · 2023-07-10T14:12:11Z

supperthomas · 2023-07-10T15:03:18Z

晚上花了点时间筛查到以下文件受影响的： https://github.com/RT-Thread/rt-thread/tree/master/bsp/airm2m/air105/libraries/rt_drivers/drv_i2c.c https://github.com/RT-Thread/rt-thread/tree/master/bsp/apollo2/board/i2c.c https://github.com/RT-Thread/rt-thread/tree/master/bsp/ESP32_C3/drivers/drv_hw_i2c.c https://github.com/RT-Thread/rt-thread/tree/master/bsp/imxrt/libraries/drivers/drv_i2c.c https://github.com/RT-Thread/rt-thread/tree/master/bsp/loongson/ls1cdev/drivers/hw_i2c.c https://github.com/RT-Thread/rt-thread/tree/master/bsp/lpc54114-lite/drivers/drv_i2c.c https://github.com/RT-Thread/rt-thread/tree/master/bsp/microchip/common/board/sam_i2c.c https://github.com/RT-Thread/rt-thread/tree/master/bsp/nuvoton/libraries/m031/rtt_port/drv_i2c.c https://github.com/RT-Thread/rt-thread/tree/master/bsp/nuvoton/libraries/m2354/rtt_port/drv_i2c.c https://github.com/RT-Thread/rt-thread/tree/master/bsp/nuvoton/libraries/m460/rtt_port/drv_i2c.c https://github.com/RT-Thread/rt-thread/tree/master/bsp/nuvoton/libraries/m460/rtt_port/drv_ui2c.c https://github.com/RT-Thread/rt-thread/tree/master/bsp/nuvoton/libraries/m480/rtt_port/drv_i2c.c https://github.com/RT-Thread/rt-thread/tree/master/bsp/nuvoton/libraries/ma35/rtt_port/drv_i2c.c https://github.com/RT-Thread/rt-thread/tree/master/bsp/nuvoton/libraries/n9h30/rtt_port/drv_i2c.c https://github.com/RT-Thread/rt-thread/tree/master/bsp/nuvoton/libraries/nuc980/rtt_port/drv_i2c.c https://github.com/RT-Thread/rt-thread/tree/master/bsp/raspberry-pi/raspi3-32/driver/drv_i2c.c https://github.com/RT-Thread/rt-thread/tree/master/bsp/raspberry-pi/raspi3-64/driver/drv_i2c.c https://github.com/RT-Thread/rt-thread/tree/master/bsp/raspberry-pi/raspi4-32/driver/drv_i2c.c https://github.com/RT-Thread/rt-thread/tree/master/bsp/w60x/drivers/drv_i2c.c 现在已全部修改好了

好的，非常感谢PR。这个改动比较大，需要其他reviewer 查看，谢谢。

has changed

* [bsp][rt-spark] Update README.md * [ci][action] add the repo check for self-use * [bsp][stm32] add B-U585I-IOT02A BSP (RT-Thread#7778) B-U585I-IOT02A芯片为STM32U585AIIxQ，与stm32u575-st-nucleo板卡接近，因此参考stm32u575-st-nucleo对B-U585I-IOT02A板卡的BSP进行了实现 * [bsp][Infineon] Add I2C4 config for psoc6-evaluationkit * [SAL/SOCKET]修复在 RT_DEBUG 开启后，调用 closesocket 接口触发断言的 BUG * 【dd2.0】Support the Core API for dd2.0 (RT-Thread#7791) * [libcpu]fix RT_ASSERT undefine (RT-Thread#7816) * [components][i2c] 优化 controt 接口格式，增加可用命令 (RT-Thread#7806) 原来 rt_i2c_control 只能执行 RT_I2C_DEV_CTRL_CLK 单一命令，通过此修改可以支持更多可用命令 * [libcpu][cortex-a]modified start_gcc.S (RT-Thread#7810) * AArch64: fixup fpu storage's size in stack and append Q16 ~ Q31 (RT-Thread#7815) Signed-off-by: GuEe-GUI <GuEe-GUI@github.com> * [time]时钟框架重构 (RT-Thread#7794) * [libcpu][arc]修复arc架构线程切换bug (RT-Thread#7825) * [add] add msp432e401y-LaunchPad BSP v0.1 * [bsp][Infineon]fix i2c init error (RT-Thread#7817) 添加iic4的配置，将初始化错误断言部分修改为打印方式 * [github] Add the code_owner review quest * [component/lwp] support more feature of signal from IEEE Std 1003.1-2017 (RT-Thread#7828) Signed-off-by: Shell <smokewood@qq.com> * [bsp][stm32][airm2m]<pin>更新pin num命令 (RT-Thread#7390) * [components][net][sal][socket] Fix duplicate free on allocated buffer - Avoid duplicate free as the d->vnode will be freed in the fd_release API call Signed-off-by: Fan YANG <fan.yang@hpmicro.com> * ✨ feat(ktime): add RT_USING_KTIME to kconfig build * [github] coder reviewer change * overflow is invalid in oneshot mode * [libc][time] cleanup code * [smart] fix possible memory leak (RT-Thread#7832) Signed-off-by: Shell <smokewood@qq.com> * [debug] 整理debug宏并增加RT_DEBUGING_CONTEXT (RT-Thread#7805) * clean up rtthread.h (RT-Thread#7843) * [ci] add paths-ignore for format and static check (RT-Thread#7845) * [ci] update code owner (RT-Thread#7846) * modify some function prototypes of the dfs_file_ops structure and the function declarations based on it (RT-Thread#7849) * [tools][mdk] fix .uvoptx/uvopt project name e.g. scons --target=mdk5/4 --project-path='test' will generate the test.uvoptx/uvopt file correctly * [tools] --project-name= can use name with space * [doc][env] update env document * [smart] 修复用户态 mq_receive 不能阻塞 (RT-Thread#7836) * [bsp][esp32-c3] Realization of scons compilation of ESP32-C3 | 实现ESP32-C3的scons编译 (RT-Thread#7821) Co-authored-by: Supper Thomas <78900636@qq.com> * [libcpu/arm] fix race condition with ldrex,strex (RT-Thread#7842) Signed-off-by: Shell <smokewood@qq.com> * 更新瑞萨相关 bsp (RT-Thread#7858) * AArch64: fixup HW atomic_t ops type from dword to qword (RT-Thread#7861) Signed-off-by: GuEe-GUI <GuEe-GUI@github.com> * [smart] fix the setup of fake lwp in sys_execve (RT-Thread#7855) * AArch64: support public linker scripts (RT-Thread#7831) Signed-off-by: GuEe-GUI <GuEe-GUI@github.com> * [bsp][wch] fix UART IRQ declarion 将UART4后的中断函数声明改为UART * [docs][qemu] update quick_start_qemu_windows * [codeowners] add /documentation owners * [doc][qemu] update qemu for windows doc * [debug] fix the error when disable RT_USING_DEBUG * 【dd2.0】move the core header files to include/drivers/core * 🐞 fix(ktime): fix wrong boottime 因为tick从中断到设置中间的时延特别大，因此暂不采用tick做基准时间，直接取gtime的cnt做基准时间 * 🐞 fix(rtc/soft_rtc): fix wrong time use boottime as soft_rtc time source * 🐞 fix(ktime/hrtimer): fix ctrl c * 📃 docs(ktime/readme): add readme * [dfs v2]fix fcntl(F_SETFL) bug,and modify the error code when opening… (RT-Thread#7878) * [syscall][socket]fix socket addr bug (RT-Thread#7876) * Add the system call eventfd (RT-Thread#7835) * [debug] use LOG_D instead RT_DEBUG_LOG related: RT-Thread#7799 * [drivers/core] revise the macros of header files the macros is too common to use so that to avoid conflicts * [drivers/ipc] fix the recursive including if legacy enabled * [ci][kconfig][qemu] guard the legacy option * [.github] add CONTRIBUTING.md https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/setting-guidelines-for-repository-contributors * [docs] add env vscode document * [bsp][pico]add: drv_spi and drv_i2c * [components/ctime] fix the free of rt_work (RT-Thread#7882) Signed-off-by: Shell <smokewood@qq.com> * [libcpu/Kconfig] add ARCH_ARM_CORTEX_M23 define (RT-Thread#7895) * [components][fal] remove some assert. * [components][utilities][var_export] update the var export auto init to board_init. * [sdio]开启emmc内部cache加快传输 (RT-Thread#7896) * Add the system call epoll (RT-Thread#7893) * [RTduino][stm32-f401nucleo] 支持对接引脚的功能切换 (RT-Thread#7901) * Prepare some api for DM (RT-Thread#7894) Signed-off-by: GuEe-GUI <GuEe-GUI@github.com> * [bsp] phytium e2000 update (RT-Thread#7900) Co-authored-by: zhugengyu <zhugengyu@phytium.com.cn> * update dfs (RT-Thread#7887) * [bsp][renesas]update ra6m3&4 readme * [lwp] 修复错误码误用 (RT-Thread#7906) * [DFS_V1] 修复close失败后不释放fd导致内存被永久占用且无法释放 (RT-Thread#7907) * [components][drivers][sdio] Fix minor issue in sdio driver (RT-Thread#7904) Signed-off-by: Fan YANG <fan.yang@hpmicro.com> * [smart] Fix bugs on lwp kill (RT-Thread#7892) Signed-off-by: Shell <smokewood@qq.com> * Add fops for dfs_v2 and rt_set_errno (RT-Thread#7910) * [kernel][mutex] 去除mutex中的递归 * [bsp][stm32][drv_spi.c] remove meaningless settings * [bsp][Phytium] qspi debug (RT-Thread#7914) * [ci] add the manual trigger;add the fail bsp check (RT-Thread#7919) * [rtduino][stm32-f401] support timer9 as tone timer * [rtduino][stm32-l476] add LED_BUILTIN * [bsp][stm32h750_artpi] use gnu99 * fix some variables not used warnings when build. (RT-Thread#7925) * update components & lwp. (RT-Thread#7888) * avoid warning message of sequence-point board/ports/touch/gt911/src/gt911.c: warning: operation on '*(config + 8)' may be undefined [-Wsequence-point] config[8] = config[8] ^= (1 << 3); ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~ * [libc][time] silence the incorrect type warning * rt_hw_cpu_reset: remove all other rt_weak * rt_hw_cpu_shutdown: implement default weak function and remvoe duplicated default functions in each cpu/bsp level * [libcpu][risc-v][common] Avoid using t0 before being saved - Fixed the issue that t0 was modified unexpectedly before being saved Signed-off-by: Fan YANG <fan.yang@hpmicro.com> * [stm32][pandora] fix LCD init ahead PWM * [SAL] fix the IPv4&v6 compiling issue. (RT-Thread#7938) * [bsp/ifx] add cyw43012 wifi module * [libcpu][risc-v][common] Fix application crash on risc-v soc if FPU is enabled - Defined ARCH_RISCV_FPU once the __riscv_flen macro was detected Signed-off-by: Fan YANG <fan.yang@hpmicro.com> * fix dfs_file_open error code (RT-Thread#7942) * fix mkdir error code. (RT-Thread#7944) * fix lwp_free tty switch to foreground error (RT-Thread#7945) * [libc][timezone] implement lightweith timezone configuration * [device][rtc] support output UTC minutes level * [libc][time] pre-support fully version timezone and daylight saving time * [bsp][stm32][rt-spark] 更新 cubemx ports * [bsp][hpmicro] Update libraries, add new BSPs - Updated hpm_sdk in libraries - Updated rt-thread driver adapter - Updated bsp for hpm6750evkmini - Updated bsp for hpm6750evk - Added bsp for hpm6750evk2 - Added bsp for hpm6300evk - Added bsp for hpm6200evk Signed-off-by: Fan YANG <fan.yang@hpmicro.com> * fix msh exec permission denied (RT-Thread#7943) * 🎈 perf(ktime): perf hrtimer, del wrong function (RT-Thread#7880) * [components/mm] add unmap page API (RT-Thread#7834) Signed-off-by: Shell <smokewood@qq.com> * [libc][posix/io/stdio] rename libc.c as posix/stdio.c * [libc][newlib] __sdidinit is obselete related: RT-Thread#7923 mirror/newlib-cygwin@44b60f0 Co-authored-by: Meco Man <920369182@qq.com> * [components][drivers][can]Init can tx completion flag before tx * [DFS_V1]修复 dfs_file_stat 一个 FATFS 根目录会失败的问题 (RT-Thread#7940) * fix list_page (RT-Thread#7968) * [bsp][gd32]添加立创开发板 GD32F470 的 SDRAM驱动，从STM32的drv_sdram.c修改而来 * [tools][gcc] remove legacy functions - GenerateGCCConfig - GenCconfigFile * [tools] add GetGCCLikePLATFORM GCC like means the toolchains which are compatible with GCC * [ci] Add more config for future use --------- Signed-off-by: GuEe-GUI <GuEe-GUI@github.com> Signed-off-by: Shell <smokewood@qq.com> Signed-off-by: Fan YANG <fan.yang@hpmicro.com> Co-authored-by: Zheng-Bicheng <58363586+Zheng-Bicheng@users.noreply.github.com> Co-authored-by: Siwei Xu <xusiwei1236@qq.com> Co-authored-by: yanghaiyong <yanghaiyong@rt-thread.com> Co-authored-by: ErikChanHub <33407169+ErikChanHub@users.noreply.github.com> Co-authored-by: sp-cai <70000077+sp-cai@users.noreply.github.com> Co-authored-by: lepus <lepustse@gmail.com> Co-authored-by: GUI <39894654+GuEe-GUI@users.noreply.github.com> Co-authored-by: xqyjlj <xqyjlj@126.com> Co-authored-by: yby <115077689+yby-oy@users.noreply.github.com> Co-authored-by: yby <1632443748@qq.com> Co-authored-by: Rbb666 <64397326+Rbb666@users.noreply.github.com> Co-authored-by: Shell <smokewood@qq.com> Co-authored-by: wangqinglin <53550140+HelloByeAll@users.noreply.github.com> Co-authored-by: Fan YANG <fan.yang@hpmicro.com> Co-authored-by: Mr.M <64891884+martin-calvin@users.noreply.github.com> Co-authored-by: Meco Man <920369182@qq.com> Co-authored-by: xiao-mang <53597406+xiao-mang@users.noreply.github.com> Co-authored-by: zhkag <zhkag@foxmail.com> Co-authored-by: WCX <timwcx@qq.com> Co-authored-by: guo <guozhanxin@rt-thread.com> Co-authored-by: bxhsiman <64024208+bxhsiman@users.noreply.github.com> Co-authored-by: erikchan <1043490933@qq.com> Co-authored-by: Tennn11 <88527847+Tennn11@users.noreply.github.com> Co-authored-by: zmq810150896 <50894086+zmq810150896@users.noreply.github.com> Co-authored-by: Shicheng Chu <1468559561@qq.com> Co-authored-by: 朱天龙 (Armink) <armink.ztl@gmail.com> Co-authored-by: heyuanjie87 <sc943313837@gmail.com> Co-authored-by: liYangYang <941843540@qq.com> Co-authored-by: zhangyan <103986797+messigogogo@users.noreply.github.com> Co-authored-by: zhugengyu <zhugengyu@phytium.com.cn> Co-authored-by: geniusgogo <2041245+geniusgogo@users.noreply.github.com> Co-authored-by: Rbb666 <zhangbingru@rt-thread.com> Co-authored-by: Junjie Wang <34395906+WKJay@users.noreply.github.com> Co-authored-by: Fan Yang <93824713+helloeagleyang@users.noreply.github.com> Co-authored-by: vacabun <maguotong66@gmail.com> Co-authored-by: DingDing <newflydd@gmail.com> Co-authored-by: KunYi Chen <kunyi.chen@gmail.com> Co-authored-by: cx <1253176313@qq.com> Co-authored-by: Bernard Xiong <bernard.xiong@gmail.com> Co-authored-by: FragrantRye <903465575@qq.com> Co-authored-by: cmbjxxiao <48663789+cmbjxxiao@users.noreply.github.com> Co-authored-by: yuanzihao <y@yzh.email>

sp-cai added 5 commits July 10, 2023 10:57

[components][i2c] Update i2c.h 优化 controt 接口为系统标准的格式

b5cf61a

由于 i2c_bus_control 的参数与系统标准的格式不同，不便于程序的扩展应用。

[components][i2c] Update i2c_dev.c 更好的可扩展性

659e9bd

原来 rt_i2c_control 只能执行 RT_I2C_DEV_CTRL_CLK 命令，为了与系统此类函数的参数格式一致且更好的可扩展性。

[components][i2c] Update i2c_core.c 更好的可扩展性

ecbe6ed

原来 rt_i2c_control 只能执行 RT_I2C_DEV_CTRL_CLK 命令，为了与系统此类函数的参数格式一致且更好的可扩展性。

[components][i2c] Update i2c_dev.h 增加可用命令

264ea9c

增加 I2C 可用操作命令。

Update i2c_dev.c

0d1ce92

supperthomas previously requested changes Jul 10, 2023

View reviewed changes

sp-cai requested a review from supperthomas July 10, 2023 10:12

sp-cai added 6 commits July 10, 2023 21:09

i2c_bus_control 形参修改

dd373dc

i2c_bus_control 形参修改

94bf8de

i2c_bus_control 形参修改

7e1dc4e

i2c_bus_control 形参修改

eb2a93c

i2c_bus_control 形参修改

1c07799

i2c_bus_control 形参修改

540c24f

supperthomas requested review from Guozhanxin and mysterywolf July 10, 2023 13:24

sp-cai added 10 commits July 10, 2023 21:26

i2c_bus_control 形参修改

4e57f9e

i2c_bus_control 形参修改

392249f

i2c_bus_control 形参修改

cc5f298

i2c_bus_control 形参修改

6a34b48

i2c_bus_control 形参修改

1e5b40d

i2c_bus_control 形参修改

4ebc555

i2c_bus_control 形参修改

8b2ce78

i2c_bus_control 形参修改

23d6568

i2c_bus_control 形参修改

d7ffa26

i2c_bus_control 形参修改

33ccd8b

sp-cai added 3 commits July 10, 2023 21:53

i2c_bus_control 形参修改

067e742

i2c_bus_control 形参修改

f11fb1e

i2c_bus_control 形参修改

35bdaab

mysterywolf approved these changes Jul 10, 2023

View reviewed changes

mysterywolf added the +1 Agree +1 label Jul 10, 2023

Guozhanxin approved these changes Jul 14, 2023

View reviewed changes

Guozhanxin added the +2 Agree +2 label Jul 14, 2023

mysterywolf merged commit 0ebec47 into RT-Thread:master Jul 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[components][i2c] 优化 controt 接口格式，增加可用命令#7806

[components][i2c] 优化 controt 接口格式，增加可用命令#7806
mysterywolf merged 24 commits into
RT-Thread:masterfrom
sp-cai:master

sp-cai commented Jul 10, 2023 •

edited

Loading

Uh oh!

supperthomas left a comment •

edited

Loading

Uh oh!

sp-cai commented Jul 10, 2023

Uh oh!

supperthomas commented Jul 10, 2023

Uh oh!

sp-cai commented Jul 10, 2023 via email

Uh oh!

supperthomas commented Jul 10, 2023

Uh oh!

sp-cai commented Jul 10, 2023

Uh oh!

sp-cai commented Jul 10, 2023

Uh oh!

supperthomas commented Jul 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

sp-cai commented Jul 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

拉取/合并请求描述：(PR description)

当前拉取/合并请求的状态 Intent for your PR

代码质量 Code Quality：

Uh oh!

supperthomas left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sp-cai commented Jul 10, 2023

Uh oh!

supperthomas commented Jul 10, 2023

Uh oh!

sp-cai commented Jul 10, 2023 via email

Uh oh!

supperthomas commented Jul 10, 2023

Uh oh!

sp-cai commented Jul 10, 2023

Uh oh!

sp-cai commented Jul 10, 2023

Uh oh!

supperthomas commented Jul 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sp-cai commented Jul 10, 2023 •

edited

Loading

supperthomas left a comment •

edited

Loading