fix: RAPID-4589 credentials lost after a prolonged period of time#228
Merged
Conversation
Collaborator
|
|
Contributor
Author
|
Did you update dependencies? I've added a new package |
Collaborator
|
yes |
jorgeparavicini
force-pushed
the
feat/custom-generation
branch
from
cb709d6 to
166d45c
Compare
LinoGiger
reviewed
Mar 20, 2025
LinoGiger
left a comment
LinoGiger
left a comment
Collaborator
There was a problem hiding this comment.
it seems to work for me now, but there seem to be some issues with the type checking? - did you adjust the dependencies?
kannwism
approved these changes
Mar 20, 2025
kannwism
left a comment
kannwism
left a comment
Contributor
There was a problem hiding this comment.
I don't see any token refetching logic. Is that OAuth2Session handling this internally?
Contributor
Author
Exactly. It is explained here how it works: |
LinoGiger
pushed a commit
that referenced
this pull request
Jul 8, 2026
authlib was pinned to an exact ==1.6.5 incidentally by the uv migration (#407), which froze the then-resolved version. It was originally added in #228 as a flexible ^1.5.1 for the OAuth2 refresh-token client and has no compatibility guard requiring an exact version. An exact pin is especially harmful in a published SDK because it forces dependency conflicts on downstream users. Relax to >=1.6.5,<2 (matching the original caret intent, floored at the currently-tested version). Verified the range resolves and that the latest 1.x (1.7.2) imports the OAuth2Client/OAuthError used by the SDK cleanly under the existing httpx<0.29 constraint. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: RapidPoseidon <poseidon@rapidata.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.