chore(deps): relax authlib pin to >=1.6.5,<2#654
Merged
Conversation
authlib was pinned to an exact ==1.6.5 incidentally by the uv migration (#407), which froze the then-resolved version. It was originally added in #228 as a flexible ^1.5.1 for the OAuth2 refresh-token client and has no compatibility guard requiring an exact version. An exact pin is especially harmful in a published SDK because it forces dependency conflicts on downstream users. Relax to >=1.6.5,<2 (matching the original caret intent, floored at the currently-tested version). Verified the range resolves and that the latest 1.x (1.7.2) imports the OAuth2Client/OAuthError used by the SDK cleanly under the existing httpx<0.29 constraint. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-Authored-By: RapidPoseidon <poseidon@rapidata.ai>
|
Reviewed the diff. This is a small, well-scoped dependency change and I don't see any correctness issues. Code quality / rationale
Dependency/lockfile considerations
Security
Test coverage
Overall: looks good to merge. Only worth a quick look at the incidental |
LinoGiger
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A customer asked whether we can relax the exact
authlib==1.6.5pin in the SDK (it forces dependency conflicts in their environment).Investigation
The exact pin is not deliberate:
authlibwas added in fix: RAPID-4589 credentials lost after a prolonged period of time #228 (credentials lost after a prolonged period — the OAuth2 refresh-token client,authlib.integrations.httpx_client) as a flexible^1.5.1.==1.6.5in the uv migration (feat: migrate to uv #407), which froze the then-resolved version. There is no rationale comment and no compatibility guard requiring an exact version.An exact pin is especially harmful in a published SDK — it propagates a version conflict to every downstream consumer.
Change
Relax to
authlib>=1.6.5,<2(matches the original caret intent, floored at the currently-tested version).Verification
uv lockresolves cleanly.OAuth2Client/OAuthErrorsymbols the SDK actually uses, under the existinghttpx>=0.28.1,<0.29constraint. authlib does not cap httpx.🔗 Session: https://t-28283203d35cde.poseidon.rapidata.internal/