Skip to content

Standardize Navbar - #241

Merged
rohan09-raj merged 19 commits into
RealDevSquad:developfrom
shubham-y:navbar-change
Dec 31, 2021
Merged

Standardize Navbar#241
rohan09-raj merged 19 commits into
RealDevSquad:developfrom
shubham-y:navbar-change

Conversation

@shubham-y

Copy link
Copy Markdown
Contributor

Closes #240

@shubham-y

shubham-y commented Oct 18, 2021

Copy link
Copy Markdown
Contributor Author

Earlier(Desktop):

image

After Changes(Desktop):

  • Without Signed In User
    image

  • Signed In User
    image

Earlier(Mobile):

image

After Changes(Mobile):

  • Without Signed In User
    image

  • Signed In User
    image
    image

@shubham-y shubham-y self-assigned this Oct 19, 2021
@shubham-y shubham-y added frontend feature task A big ticket item that needs to come up as a feature labels Oct 19, 2021
@shubham-y
shubham-y marked this pull request as ready for review December 19, 2021 14:11
Comment thread components/NavBar/navbar.module.css Outdated
Comment thread styles/globals.css Outdated
Comment thread styles/globals.css Outdated
Comment thread components/NavBar/index.js Outdated

@rohan09-raj rohan09-raj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make these few changes. Rest all looks good to me. Great job @shubham-y

Comment thread components/NavBar/index.js Outdated
Comment thread components/NavBar/navbar.module.css Outdated
Comment thread styles/globals.css Outdated
Comment thread components/NavBar/navbar.module.css Outdated
Comment thread components/NavBar/navbar.module.css Outdated
Comment thread components/NavBar/index.js
Comment thread components/NavBar/index.js Outdated
Comment thread components/NavBar/navbar.module.css Outdated
Comment thread components/NavBar/index.js
@rohan09-raj
rohan09-raj merged commit f6d3658 into RealDevSquad:develop Dec 31, 2021
Comment thread components/NavBar/index.js
Comment thread components/NavBar/index.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature task A big ticket item that needs to come up as a feature frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standardize Navbar across Real Dev Squad

5 participants