[Frontend] Standardize nav-bar for status site - #245
Conversation
There was a problem hiding this comment.
Hey @akankshadharkar, we also need the Github Login button on this page, also the home should not be visible on desktop view.
Please check the designs for reference and https://www.realdevsquad.com/
|
I'll add the github login as a separate commit, this was just to standardize the current ones and make them responsive. |
Oh ok great 💯 |
whyDontI
left a comment
whyDontI
left a comment
There was a problem hiding this comment.
Good work 🥳
Requested some little changes
| @@ -1,35 +1,122 @@ | |||
| $offset: 10px; | |||
| $thickness: 3px; | |||
| .wrapper { | |||
There was a problem hiding this comment.
Can we have the CSS nested? We are using SASS nesting in other stylesheets.
https://sass-lang.com/documentation/style-rules#advanced-nesting
1287e33 to
b4c4340
Compare
akankshadharkar
changed the title
|
rohan09-raj
changed the title
|
@vvaibhavdesai Good work 👍 |
- added unconfigured host for next js - updated style for user component - replaced axios with fetch
- added types for navlinks - fixed the SignIn btnText Issue - fixed the navbarLinks issue for types
…tatus into feature/nav-bar-sync
|
Closing this PR as it got messed up due to rebasing and previous changes. This PR is further continued in #264 |
5 participants
Background
The nav-bars across all sites are not consistent and so we have tasks to make it consistent in all sites.
Implementation
This PR deals with template and styling changes for the navbar in status site.
Closes #233
Referenced CSS from RealDevSquad/website-crypto#241
Visual demo
Screen.Recording.2022-01-24.at.3.21.02.PM.mov
Note
This is my first attempt at a react/NextJS PR, please feel free to tell me better practices that I can use and improve on.