Codingstyle and refactoring#5
Closed
matthiashh wants to merge 21 commits into
Closed
Conversation
The python console output seems to have changed and includes more backslashes. Also `specType` in `serializeParamMap` was changed to 2 to 0 in all tests.
The scope is quite limited since parts need running infrastructure in the form of ROS and the world model. Found one bug that is reported as issue #4.
|
Hi Matt, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are the commits I did for our SE course. I also cherry-picked the fix for #4 since that was just applied to "develop".
I based them upon "master" which didn't seem to be the best idea, but I just noticed afterwards. So overall I'm not too sure if the changes would make sense to apply (except for the fix) since my gut feeling is that "develop" and "master" might have diverged too much to just merge them into "develop" afterwards.
But you're more familiar with the code so feel free to do what you think is best.