Applied pycodestyle (pep8) with "--aggresive"#6
Closed
matthiashh wants to merge 2 commits into
Closed
Conversation
This should fix most violations of pep8. Excemptions were made for manually structured code through tabs.
Author
This was referenced Apr 10, 2019
skiros_gui dies if rqt configuration button is pressed and this function doesn't exist.
Author
|
I didn't know that all future commits on a branch are also included in a pull request. I am closing this one in favour of one where I can merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix most violations of pep8.
Exemptions were made for manually structured code through tabs.
I use
since I think that lines can be longer than 79 characters pep8 default, but they should be limited at one point. Of course this is an arbitrary number. Github sets 125 for example.