[IMPROVE] Add emoji picker to iOS#4366
Merged
Merged
Conversation
diegolmello
requested changes
Jul 18, 2022
| return <ActionsButton onPress={showMessageBoxActions} />; | ||
| } | ||
| return <View style={styles.buttonsWhitespace} />; | ||
| return !isIOS ? <View style={styles.buttonsWhitespace} /> : null; |
Contributor
There was a problem hiding this comment.
I couldn't see a visual difference in this case here.
Contributor
Author
There was a problem hiding this comment.
The VIEW was implemented before only for Android, because of this I created this conditional. I was not able to find why this was implemented only for android. But I remember that at some point a long time ago @diegolmello commented with me about this view. So instead create a regression, I implemented this conditional.
diegolmello
changed the title
reinaldonetof
commented
Jul 20, 2022
diegolmello
requested changes
Jul 20, 2022
dnlsilva
reviewed
Jul 20, 2022
| return <ActionsButton onPress={showMessageBoxActions} />; | ||
| } | ||
| return <View style={styles.buttonsWhitespace} />; | ||
| return !isIOS ? <View style={styles.buttonsWhitespace} /> : null; |
Contributor
There was a problem hiding this comment.
I couldn't see a visual difference in this case here.
diegolmello
approved these changes
Aug 8, 2022
diegolmello
pushed a commit
that referenced
this pull request
Sep 12, 2022
* [IMPROVE] Add emoji picker to iOS * clean left and right buttons * fix the redux in emojipicker * fix behavior when emoji keyboard is openning * added isIOS * fix show reactions when emoji is open * minor tweak * add provider * fix baseurl * minor tweak * create closeEmojiAndAction and added to record * fix actionsheet for omnichannel * fix action sheet * fix close emoji when navigate to other screen * added iactionsheetprovider to roomview * clean variables * fix theme * close the emojikeyboard when click on message * apoint package.json to new pr * fix branch * fix package.json
10 tasks
ivnxyz
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
* [IMPROVE] Add emoji picker to iOS * clean left and right buttons * fix the redux in emojipicker * fix behavior when emoji keyboard is openning * added isIOS * fix show reactions when emoji is open * minor tweak * add provider * fix baseurl * minor tweak * create closeEmojiAndAction and added to record * fix actionsheet for omnichannel * fix action sheet * fix close emoji when navigate to other screen * added iactionsheetprovider to roomview * clean variables * fix theme * close the emojikeyboard when click on message * apoint package.json to new pr * fix branch * fix package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Use the same keyboard layout for both Andorid and iOS. Also, add the emoji picker on keyboard.
This task is dependent on the merge of the PR RocketChat/react-native-ui-lib#6
Issue(s)
How to test or reproduce
Screenshots
Before
After
Types of changes
Checklist
Further comments