[FIX] "Allow Reaction" does not work properly on "Read Only" rooms#4864
Merged
Conversation
dnlsilva
approved these changes
Jan 27, 2023
reinaldonetof
commented
Jan 31, 2023
Comment on lines
+788
to
+796
| handleCloseEmoji = (action?: Function, params?: any) => { | ||
| if (this.messagebox?.current) { | ||
| return this.messagebox?.current.closeEmojiAndAction(action, params); | ||
| } | ||
| if (action) { | ||
| return action(params); | ||
| } | ||
| }; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
I needed to do this differentiation because there is the possibility that the message box isn't rendered, for example, when the room is read only.
So, in that case, besides the possibility to reactions on long press, the user must be able to click on the emoji + to add new emoji or long press on the reactions.
diegolmello
pushed a commit
that referenced
this pull request
Mar 2, 2023
…4864) * [FIX] "Allow Reaction" does not work properly on "Read Only" rooms * fix the handle of message box --------- Co-authored-by: Gleidson Daniel Silva <gleidson10daniel@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
When the user is in a Read Only room when he does a long press, the message action doesn't appear and he isn't able to reply directly to the person who sent a message before or react to it with an emoji, or copy the permalink. This is a regression from #4366
Issue(s)
How to test or reproduce
In any channel, with a user that has the appropriate permissions
Screenshots
Before
Screen.Recording.2023-01-25.at.16.35.02.mov
After
Screen.Recording.2023-01-25.at.16.29.26.mov
Types of changes
Checklist
Further comments
TC-326