[IMPROVE] Redesign flow of create room#4381
Merged
Merged
Conversation
diegolmello
requested changes
Aug 1, 2022
diegolmello
requested changes
Aug 25, 2022
| }, | ||
| invitedHeader: { | ||
| marginTop: 18, | ||
| marginHorizontal: 15, |
Member
There was a problem hiding this comment.
16 on Figma
Everything that's not a multiple of 4 needs to be reviewed.
Ask me before commiting, if you're in doubt
| <Chip text={name} avatar={username} onPress={() => removeUser(item)} testID={`create-channel-view-item-${item.name}`} /> | ||
| ); | ||
| }, | ||
| shallowEqual |
diegolmello
approved these changes
Aug 26, 2022
10 tasks
diegolmello
added a commit
that referenced
this pull request
Sep 12, 2022
Co-authored-by: Diego Mello <diegolmello@gmail.com>
ivnxyz
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
Co-authored-by: Diego Mello <diegolmello@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
We're proposing lots of UX improvements on this task.
We're going to make use of the new Searchbox, the new forms pattern and improve the UX overall.
Issue(s)
How to test or reproduce
Screenshots
Before
Screen.Recording.2022-07-21.at.15.11.39.mov
After
Screen.Recording.2022-07-21.at.15.01.01.mov
Types of changes
Checklist
Further comments