Skip to content

Regression: Create private team and channel as default#4493

Merged
reinaldonetof merged 3 commits into
developfrom
regression.create-private-channel-as-default
Sep 9, 2022
Merged

Regression: Create private team and channel as default#4493
reinaldonetof merged 3 commits into
developfrom
regression.create-private-channel-as-default

Conversation

@reinaldonetof

Copy link
Copy Markdown
Contributor

Proposed changes

When creating a team or channel the default value of the type switch is True and this should create a private team or channel, however, the default value of the type in the state is "false", creating a public channel/team.

#4381

Issue(s)

How to test or reproduce

  • Go to Create a channel
  • You shouldn't change the Private switch value.
  • Create the channel
  • The channel should be PRIVATE as default

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@reinaldonetof reinaldonetof self-assigned this Sep 5, 2022
@reinaldonetof reinaldonetof merged commit 1bc3f54 into develop Sep 9, 2022
@reinaldonetof reinaldonetof deleted the regression.create-private-channel-as-default branch September 9, 2022 14:49
diegolmello pushed a commit that referenced this pull request Sep 12, 2022
* Regression: Create private team and channel as default

* minor tweak
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
* Regression: Create private team and channel as default

* minor tweak
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants