Skip to content

Regression: Resume the app with a deep link not navigating#4428

Merged
diegolmello merged 2 commits into
developfrom
fix.deep-linking-ios
Aug 11, 2022
Merged

Regression: Resume the app with a deep link not navigating#4428
diegolmello merged 2 commits into
developfrom
fix.deep-linking-ios

Conversation

@diegolmello

@diegolmello diegolmello commented Aug 11, 2022

Copy link
Copy Markdown
Member

Proposed changes

Introduced on #4316

Issue(s)

How to test or reproduce

  • Tapping on a notification with the app open in background should redirect to the room
  • On iOS e2e/tests/assorted/11-deeplinking.spec.js should be passing
  • On Android I couldn't make Detox work on my machine, so I tested with
adb shell am start -W -a android.intent.action.VIEW -d "https://go.rocket.chat/room\?host\=open.rocket.chat\&path\=channel/general"

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@diegolmello diegolmello marked this pull request as ready for review August 11, 2022 19:36
@diegolmello diegolmello force-pushed the fix.deep-linking-ios branch from dadb375 to ccbec78 Compare August 11, 2022 19:37
@diegolmello diegolmello merged commit b389427 into develop Aug 11, 2022
@diegolmello diegolmello deleted the fix.deep-linking-ios branch August 11, 2022 19:40
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants