[FIX] Requests being skipped after reconnecting on onboarding#4429
Merged
Conversation
10 tasks
dnlsilva
approved these changes
Aug 12, 2022
b5556c5 to
d269857
Compare
diegolmello
added a commit
that referenced
this pull request
Sep 12, 2022
ivnxyz
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
We were calling
abortonselectServersaga without need.The app doesn't disconnect if it's reconnecting to the same server, but it would abort upcoming requests anyway.
Calling
abortinvalidatesthis.controllerfrom@rocket.chat/sdkhttps://github.com/RocketChat/Rocket.Chat.js.SDK/blob/mobile/lib/api/api.ts#L260I wrote a regression test to make sure it doesn't happen again.
Issue(s)
Depends on #4428
How to test or reproduce
@rocket.chat/sdkis going to be abortedScreenshots
Types of changes
Checklist
Further comments