Skip to content

[FIX] Requests being skipped after reconnecting on onboarding#4429

Merged
diegolmello merged 3 commits into
developfrom
fix.reconnect
Aug 17, 2022
Merged

[FIX] Requests being skipped after reconnecting on onboarding#4429
diegolmello merged 3 commits into
developfrom
fix.reconnect

Conversation

@diegolmello

Copy link
Copy Markdown
Member

Proposed changes

We were calling abort on selectServer saga without need.
The app doesn't disconnect if it's reconnecting to the same server, but it would abort upcoming requests anyway.
Calling abort invalidates this.controller from @rocket.chat/sdk https://github.com/RocketChat/Rocket.Chat.js.SDK/blob/mobile/lib/api/api.ts#L260

I wrote a regression test to make sure it doesn't happen again.

Issue(s)

Depends on #4428

How to test or reproduce

  • Tap join open
  • Go back
  • Tap join open again
  • From now on, any request happening through @rocket.chat/sdk is going to be aborted

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@diegolmello diegolmello merged commit c4d3af0 into develop Aug 17, 2022
@diegolmello diegolmello deleted the fix.reconnect branch August 17, 2022 12:49
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants