[FIX] Search in Rooms List crashes Android app#4546
Merged
Conversation
dnlsilva
approved these changes
Sep 22, 2022
10 tasks
diegolmello
pushed a commit
that referenced
this pull request
Sep 28, 2022
* [FIX] Search in Rooms List crashes Android app * back to previous search * change the method/searchlocal
ivnxyz
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
* [FIX] Search in Rooms List crashes Android app * back to previous search * change the method/searchlocal
ivnxyz
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
* [FIX] Search in Rooms List crashes Android app * back to previous search * change the method/searchlocal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
When searching in RoomsListView each request is forcing a dequal between the new state of search and the previous one. When the search text is void or small, some rooms came from a query from watermelonDb, and this implicates a lot of params beyond the
_rawparams that are needed to compare.Issue(s)
How to test or reproduce
Screenshots
Before
Screen.Recording.2022-09-21.at.00.09.16.mov
After
Screen.Recording.2022-09-21.at.00.07.38.mov
Types of changes
Checklist
Further comments