Skip to content

Regression: Local search is returning wrong object#4567

Merged
reinaldonetof merged 1 commit into
developfrom
regression.local-search
Sep 27, 2022
Merged

Regression: Local search is returning wrong object#4567
reinaldonetof merged 1 commit into
developfrom
regression.local-search

Conversation

@reinaldonetof

@reinaldonetof reinaldonetof commented Sep 27, 2022

Copy link
Copy Markdown
Contributor

Proposed changes

TC-119

This regression was introduced here. Unfortunately, during this PR #4546 I added 3 params that weren't needed or was incorrect as the search: true.

Issue(s)

How to test or reproduce

  • Try to mention a channel that you already joined before
  • Create a dm with someone, then back to create a channel and select the previous person that you started to sent a dm

Screenshots

Before

Screen Shot 2022-09-27 at 13 43 47

Screen Shot 2022-09-27 at 13 44 34

After

Screen Shot 2022-09-27 at 13 45 28

Screen Shot 2022-09-27 at 13 46 29

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@reinaldonetof reinaldonetof self-assigned this Sep 27, 2022
@reinaldonetof reinaldonetof merged commit d2d1d78 into develop Sep 27, 2022
@reinaldonetof reinaldonetof deleted the regression.local-search branch September 27, 2022 18:08
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants