Create groups.addAll endpoint and add activeUsersOnly param.#6505
Merged
engelgabriel merged 2 commits intoMar 29, 2017
Merged
Conversation
|
|
nathanmarcos
changed the title
graywolf336
suggested changes
Mar 28, 2017
| @@ -1,7 +1,8 @@ | |||
| Meteor.methods({ | |||
| addAllUserToRoom(rid) { | |||
| addAllUserToRoom(rid, activeUsersOnly) { | |||
Contributor
There was a problem hiding this comment.
What about changing this so that it defaults to false making it an optional parameter with a default value? Something like: activeUsersOnly = false
Author
There was a problem hiding this comment.
Totally agreed! I'll make the changes.
Contributor
There was a problem hiding this comment.
Thanks for the pull requests and being flexible! :)
graywolf336
approved these changes
Mar 28, 2017
graywolf336
left a comment
graywolf336
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this! To whoever merges this, please also merge this at the same time: RocketChat/docs-old#265
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
We need to add all active users to a private group or a channel, so we created the new groups.addAll endpoint and added the activeUsersOnly to addAllUsersToRoom.js