This repository was archived by the owner on Mar 17, 2023. It is now read-only.
Add docs to groups.addAll endpoint and activeUsersOnly param.#265
Merged
engelgabriel merged 3 commits intoMar 29, 2017
Conversation
graywolf336
suggested changes
Mar 28, 2017
| | Argument | Example | Required | Description | | ||
| | :--- | :--- | :--- | :--- | | ||
| | `roomId` | `ByehQjC44FwMeiLbX` | Required | The channel's id | | ||
| | `activeUsersOnly` | `true` | Optional <br> Default: `undefined` | Add active users only | |
Contributor
There was a problem hiding this comment.
Technically it is undefined, but for sake of understanding that the default is false what about changing this to false? Since your code to add this only checks if the value equals true?
Contributor
Author
There was a problem hiding this comment.
Totally agreed! I'll make the changes.
graywolf336
suggested changes
Mar 28, 2017
graywolf336
left a comment
graywolf336
left a comment
Contributor
There was a problem hiding this comment.
Thanks for making the change, think you can edit the "Change Log" at the bottom of the pages? We can just assume the next version and if it doesn't make it by then, we'll just update it to the correct version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs to RocketChat/Rocket.Chat/pull/6505