k256/p256: bump ff and group deps to v0.8; MSRV 1.44+#174
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
==========================================
- Coverage 58.50% 58.21% -0.30%
==========================================
Files 25 25
Lines 3767 3786 +19
==========================================
Hits 2204 2204
- Misses 1563 1582 +19
Continue to review full report at Codecov.
|
Member
Author
|
It seems Interestingly enough, since I'll look at working around the issue for now, but it'd sure be great to have a 32-bit scalar field implementation as well, particularly if /cc @str4d |
tarcieri
force-pushed
the
bump-ff-and-group-crates-to-v0.8
branch
2 times, most recently
from
a1d5ac0 to
3fff761
Compare
tarcieri
commented
Sep 9, 2020
tarcieri
force-pushed
the
bump-ff-and-group-crates-to-v0.8
branch
2 times, most recently
from
1da3219 to
7ba3f83
Compare
tarcieri
commented
Sep 9, 2020
tarcieri
force-pushed
the
bump-ff-and-group-crates-to-v0.8
branch
from
7ba3f83 to
9019357
Compare
Previously the `elliptic-curve` crate was depending on pre-releases of `ff` and `group` sourced via git. It was upgraded to use the final releases in RustCrypto/traits#292. Because these crates depend on `bitvec` and its transitive dependencies, an `arithmetic` feature was added to `elliptic-curve` in RustCrypto/traits#293. This commit upgrades the `k256` and `p256` crates to use the final releases of `ff` and `group`. This ended up actually being a relatively straightforward upgrade because we were already running off the latest versions sourced from git. The major notable change is `PrimeField::ReprBits` and the `to_le_bits` and `char_le_bits` methods for obtaining `bitvec`-friendly types for representing field elements.
tarcieri
force-pushed
the
bump-ff-and-group-crates-to-v0.8
branch
from
9019357 to
be0da51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the
elliptic-curvecrate was depending on pre-releases offfandgroupsourced via git. It was upgraded to use the final releases in RustCrypto/traits#292.Because these crates depend on
bitvecand its transitive dependencies, anarithmeticfeature was added toelliptic-curvein RustCrypto/traits#293.This commit upgrades the
k256andp256crates to use the final releases offfandgroup. This ended up actually being a relatively straightforward upgrade because we were already running off the latest versions sourced from git.The major notable change is
PrimeField::ReprBitsand theto_le_bitsandchar_le_bitsmethods for obtainingbitvec-friendly types for representing field elements.