elliptic-curve: add arithmetic feature#293
Merged
Merged
Conversation
This crate now has a large(r) number of dependencies via the `ff` and `group` crates (notably the recently introduced `bitvec` and its transitive dependencies). This commit adds an `arithmetic` feature and gates related functionality under it, along with the `ff` and `group` crate dependencies. This ensures these dependencies (and their transitive dependencies) can be excluded when the `arithmetic` features of elliptic curve implementations are non-existent or an associated feature disabled.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 9, 2020
Previously the `elliptic-curve` crate was depending on pre-releases of `ff` and `group` sourced via git. It was upgraded to use the final releases in RustCrypto/traits#292. Because these crates depend on `bitvec` and its transitive dependencies, an `arithmetic` feature was added to `elliptic-curve` in RustCrypto/traits#293. This commit upgrades the `k256` and `p256` crates to use the final releases of `ff` and `group`. This ended up actually being a relatively straightforward upgrade because we were already running off the latest versions sourced from git. The major notable change is `PrimeField::ReprBits` and the `to_le_bits` and `char_le_bits` methods for obtaining `bitvec`-friendly types for representing field elements.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 9, 2020
Previously the `elliptic-curve` crate was depending on pre-releases of `ff` and `group` sourced via git. It was upgraded to use the final releases in RustCrypto/traits#292. Because these crates depend on `bitvec` and its transitive dependencies, an `arithmetic` feature was added to `elliptic-curve` in RustCrypto/traits#293. This commit upgrades the `k256` and `p256` crates to use the final releases of `ff` and `group`. This ended up actually being a relatively straightforward upgrade because we were already running off the latest versions sourced from git. The major notable change is `PrimeField::ReprBits` and the `to_le_bits` and `char_le_bits` methods for obtaining `bitvec`-friendly types for representing field elements.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 9, 2020
Previously the `elliptic-curve` crate was depending on pre-releases of `ff` and `group` sourced via git. It was upgraded to use the final releases in RustCrypto/traits#292. Because these crates depend on `bitvec` and its transitive dependencies, an `arithmetic` feature was added to `elliptic-curve` in RustCrypto/traits#293. This commit upgrades the `k256` and `p256` crates to use the final releases of `ff` and `group`. This ended up actually being a relatively straightforward upgrade because we were already running off the latest versions sourced from git. The major notable change is `PrimeField::ReprBits` and the `to_le_bits` and `char_le_bits` methods for obtaining `bitvec`-friendly types for representing field elements.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 9, 2020
Previously the `elliptic-curve` crate was depending on pre-releases of `ff` and `group` sourced via git. It was upgraded to use the final releases in RustCrypto/traits#292. Because these crates depend on `bitvec` and its transitive dependencies, an `arithmetic` feature was added to `elliptic-curve` in RustCrypto/traits#293. This commit upgrades the `k256` and `p256` crates to use the final releases of `ff` and `group`. This ended up actually being a relatively straightforward upgrade because we were already running off the latest versions sourced from git. The major notable change is `PrimeField::ReprBits` and the `to_le_bits` and `char_le_bits` methods for obtaining `bitvec`-friendly types for representing field elements.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 9, 2020
Previously the `elliptic-curve` crate was depending on pre-releases of `ff` and `group` sourced via git. It was upgraded to use the final releases in RustCrypto/traits#292. Because these crates depend on `bitvec` and its transitive dependencies, an `arithmetic` feature was added to `elliptic-curve` in RustCrypto/traits#293. This commit upgrades the `k256` and `p256` crates to use the final releases of `ff` and `group`. This ended up actually being a relatively straightforward upgrade because we were already running off the latest versions sourced from git. The major notable change is `PrimeField::ReprBits` and the `to_le_bits` and `char_le_bits` methods for obtaining `bitvec`-friendly types for representing field elements.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 9, 2020
Previously the `elliptic-curve` crate was depending on pre-releases of `ff` and `group` sourced via git. It was upgraded to use the final releases in RustCrypto/traits#292. Because these crates depend on `bitvec` and its transitive dependencies, an `arithmetic` feature was added to `elliptic-curve` in RustCrypto/traits#293. This commit upgrades the `k256` and `p256` crates to use the final releases of `ff` and `group`. This ended up actually being a relatively straightforward upgrade because we were already running off the latest versions sourced from git. The major notable change is `PrimeField::ReprBits` and the `to_le_bits` and `char_le_bits` methods for obtaining `bitvec`-friendly types for representing field elements.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 9, 2020
Previously the `elliptic-curve` crate was depending on pre-releases of `ff` and `group` sourced via git. It was upgraded to use the final releases in RustCrypto/traits#292. Because these crates depend on `bitvec` and its transitive dependencies, an `arithmetic` feature was added to `elliptic-curve` in RustCrypto/traits#293. This commit upgrades the `k256` and `p256` crates to use the final releases of `ff` and `group`. This ended up actually being a relatively straightforward upgrade because we were already running off the latest versions sourced from git. The major notable change is `PrimeField::ReprBits` and the `to_le_bits` and `char_le_bits` methods for obtaining `bitvec`-friendly types for representing field elements.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 9, 2020
Previously the `elliptic-curve` crate was depending on pre-releases of `ff` and `group` sourced via git. It was upgraded to use the final releases in RustCrypto/traits#292. Because these crates depend on `bitvec` and its transitive dependencies, an `arithmetic` feature was added to `elliptic-curve` in RustCrypto/traits#293. This commit upgrades the `k256` and `p256` crates to use the final releases of `ff` and `group`. This ended up actually being a relatively straightforward upgrade because we were already running off the latest versions sourced from git. The major notable change is `PrimeField::ReprBits` and the `to_le_bits` and `char_le_bits` methods for obtaining `bitvec`-friendly types for representing field elements.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 9, 2020
Previously the `elliptic-curve` crate was depending on pre-releases of `ff` and `group` sourced via git. It was upgraded to use the final releases in RustCrypto/traits#292. Because these crates depend on `bitvec` and its transitive dependencies, an `arithmetic` feature was added to `elliptic-curve` in RustCrypto/traits#293. This commit upgrades the `k256` and `p256` crates to use the final releases of `ff` and `group`. This ended up actually being a relatively straightforward upgrade because we were already running off the latest versions sourced from git. The major notable change is `PrimeField::ReprBits` and the `to_le_bits` and `char_le_bits` methods for obtaining `bitvec`-friendly types for representing field elements.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 9, 2020
Previously the `elliptic-curve` crate was depending on pre-releases of `ff` and `group` sourced via git. It was upgraded to use the final releases in RustCrypto/traits#292. Because these crates depend on `bitvec` and its transitive dependencies, an `arithmetic` feature was added to `elliptic-curve` in RustCrypto/traits#293. This commit upgrades the `k256` and `p256` crates to use the final releases of `ff` and `group`. This ended up actually being a relatively straightforward upgrade because we were already running off the latest versions sourced from git. The major notable change is `PrimeField::ReprBits` and the `to_le_bits` and `char_le_bits` methods for obtaining `bitvec`-friendly types for representing field elements.
Merged
dns2utf8
pushed a commit
to dns2utf8/traits
that referenced
this pull request
Jan 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This crate now has a large(r) number of dependencies via the
ffandgroupcrates (notably the recently introducedbitvecand its transitive dependencies).This commit adds an
arithmeticfeature and gates related functionality under it, along with theffandgroupcrate dependencies.This ensures these dependencies (and their transitive dependencies) can be excluded when the
arithmeticfeatures of elliptic curve implementations are non-existent or an associated feature disabled.